Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.1] #9247 fixed layout handle for cms page #13489

Conversation

simpleadm
Copy link
Contributor

Backported pull request #9247

Description

Cms module adds additional layout update handle with identifier on page view. Following problems appear when user use slashes in page identifier (e.g. cms/page):

  1. Impossible to use custom layout update file (e.g. cms_page_view_id_cms_page)
  2. Menu missing when varnish full page cache enable (relevant only for 2.0 and 2.1 branches)
  3. Wrong layout handle format

Manual testing scenarios

  1. Enable varnish full page cache under Stores > Configuration > Advanced > System > Full Page Cache > Caching Application
  2. Create new cms page
  3. Provide URL Key with slashes (e.g. cms/page)
  4. Check result on frontend (menu will be missing)

@orlangur orlangur self-assigned this Feb 5, 2018
@orlangur orlangur added this to the February 2018 milestone Feb 5, 2018
@magento-engcom-team
Copy link
Contributor

@simpleadm thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@simpleadm
Copy link
Contributor Author

@magento-engcom-team invitation has been accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants