[Backport to 2.1-develop] Fix #10812: htaccess Options override #12959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed options All from .htaccess. All is the default option.
magento-engcom-team
added
Fixed in 2.2.x
magento-team
pushed a commit
that referenced
this pull request
Jan 8, 2018
magento-engcom-team
added
Fixed in 2.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for isse Fix #10812.
The Apache documentation for the Options Directive mentions the following:
Warning
Mixing Options with a + or - with those without is not valid syntax and is likely to cause unexpected results.
http://httpd.apache.org/docs/2.2/mod/core.html#options
So occording to the documentation "Options All -Indexes" is not valid syntax. Removed the option "All" from the .htaccess file. This is the default option. We only want to make sure that the Indexes option is not present, so that Apache will not return a list of files in the directory. The ExecCGI option will be disabled by the .htaccess as well. The FollowSymLinks option will be set automatically when the mod_rewrite module is found. As far is I can see there is no need to set or unset the other options in the Options Directive, so it's safe to remove the option All from the .htaccess files.
Backport
This PR is a backport of: #11327