Fix broken link in CHANGELOG.md #1282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, link to this repository happened to be broken, but it seems to me that the idea was to have "Data Migration Tool repository" link title and "repository" link text. I've checked Markdown syntax documentation, it could be achieved by using just a space instead of commar separator: Tried this variant in action: https://github.com/orlangur/magento2/blob/patch-2/CHANGELOG.md Could you please adjust your pull request accordingly? To keep a history cleaner, would be nice to perform force push into your pull request branch. |
|
You've already made the change yourself so just go ahead and merge that :). |
magento-team
pushed a commit
that referenced
this pull request
Jan 25, 2018
- Merge Pull Request magento-engcom/magento2ce#1282 from magento-engcom-team/magento2:batch-1-forwardport-2.3-develop - Merged commits: 1. 2e33a0b 2. 6ff2534 3. 2817416 4. 9701bb7 5. ed5d239 6. c739ef6 7. 3238020 8. b9df95d 9. b68a790 10. b8e7c76 11. eadec83 12. 6e6e27d 13. 44d5334 14. 316c516 15. ba46794 16. d5067cf 17. baf146c 18. 3a13b6d 19. 5b47596 20. 45b7f66
magento-team
pushed a commit
that referenced
this pull request
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.