Skip to content

Conversation

@lionelalvarez
Copy link
Contributor

Description

Change less styles for field-control so datepicker fields do not appear out of place

Fixed Issues (if relevant)

  1. Datepicker does not scroll #7903: Datepicker does not scroll

Manual testing scenarios

  1. As described in the issue

Related PRs

#12045

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vkublytskyi vkublytskyi self-assigned this Nov 6, 2017
@vkublytskyi vkublytskyi added this to the November 2017 milestone Nov 6, 2017
@vkublytskyi vkublytskyi added Release Line: 2.2 2.2.x bug report Area: Frontend Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 6, 2017
@vkublytskyi vkublytskyi added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Nov 22, 2017
@vkublytskyi
Copy link

@lionelalvarez This fix cannot be merged to 2.2-develop as is because it introduces a new bug.

Steps to reproduce:

  1. Log In to Admin Panel
  2. Open Catalog > Products > Add Simple Product
  3. Click on Advanced Pricing
  4. In opened pop-up click Add in Catalog and Tier Price row
  5. Click on Group or Catalog dropdown control
    Actual Result: drop-down items are hovered by parent element and are not usable
    Expected Result: drop-down items are visible and are on top of parent elements

createvirtualproductentitytest_failure

@magento-engcom-team
Copy link
Contributor

@lionelalvarez thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@sidolov
Copy link
Contributor

sidolov commented Apr 4, 2018

Hi @lionelalvarez , any updates?

@lionelalvarez
Copy link
Contributor Author

lionelalvarez commented Apr 4, 2018 via email

@okorshenko okorshenko modified the milestones: March 2018, April 2018 Apr 16, 2018
@sidolov
Copy link
Contributor

sidolov commented May 5, 2018

@lionelalvarez , I am closing this PR now due to inactivity.
Please reopen it when you have time to continue!
Thank you for collaboration!

@sidolov sidolov closed this May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Frontend bug report bugfix Fixed in 2.1.x The issue has been fixed in 2.1 release line Progress: needs update Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants