Email sending events #1202
Email sending events #1202
Conversation
|
@fooman, Do not you think that is strange to copy the same code in different places? I believe that same can be implemented using Interceptors |
|
@kandy strange? possibly. I have only started working with Magento2 and it seems to require a lot more explicit code mentions to get things done (most of the code is really getting the event manager into the functions). How the code is currently structured I don't think the interceptor approach will work as well. However feel free to create a different pull request for Magento to consider. |
|
Looks like the latest version created a merge conflict. Will take a look into this after Imagine. |
|
@fooman, did you have a time to look at conflict? |
Conflicts: app/code/Magento/Sales/Model/Order/Email/Sender/CreditmemoCommentSender.php app/code/Magento/Sales/Model/Order/Email/Sender/CreditmemoSender.php app/code/Magento/Sales/Model/Order/Email/Sender/InvoiceCommentSender.php app/code/Magento/Sales/Model/Order/Email/Sender/InvoiceSender.php app/code/Magento/Sales/Model/Order/Email/Sender/OrderCommentSender.php app/code/Magento/Sales/Model/Order/Email/Sender/OrderSender.php app/code/Magento/Sales/Model/Order/Email/Sender/ShipmentCommentSender.php app/code/Magento/Sales/Model/Order/Email/Sender/ShipmentSender.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/AbstractSenderTest.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/CreditmemoCommentSenderTest.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/CreditmemoSenderTest.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/InvoiceCommentSenderTest.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/InvoiceSenderTest.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/OrderCommentSenderTest.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/OrderSenderTest.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/ShipmentCommentSenderTest.php app/code/Magento/Sales/Test/Unit/Model/Order/Email/Sender/ShipmentSenderTest.php
|
Just catching up - have taken care of the merge conflicts. |
vpelipenko
added
Progress: accept
Issue: Ready for Work
|
CR: passed |
Part of the same project as Pull Requests #1199 and #1201 - refer there for background information.
This pull requests adds events during the email sending process of transactional sales emails. The events allows any extension to add arbitrary objects to be used in the email templates.