11532: Duplicate Simple Product Throws Error: Undefined offset: 0 in SaveHandler.php on line 122

[RomaKis]

Fixed Issues (if relevant)

1. Duplicate Simple Product Throws Error: Undefined offset: 0 in SaveHandler.php on line 122 #11532: Duplicate Simple Product Throws Error: Undefined offset: 0 in SaveHandler.php on line 122

Manual testing scenarios

Precondition
Two cases:
Create simple product and export his, delete product in catalog manager, and import file from product.
or
Create simple product, and update Magento from 2.1.8 or 2.1.9 to 2.2.0.
Steps to reproduce:

1. Click on an existing simple product in the catalog manager
2. Click the "Save & Duplicate" option
   Expected result
   The product saves and creates a duplicate item.
   Actual result
   Saves the product but doesn't duplicate it. Throws the following error:
   Notice: Undefined offset: 0 in /home/store/public_html/vendor/magento/module-catalog/Model/Category/Link/SaveHandler.php on line 122

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[dmanners]

Personally I do not think we need the nested if here. I think we could cover this check via

} elseif (
    isset($oldCategoryPositions[$key])
    && $oldCategoryPositions[$key]['position'] != $newCategoryPosition['position']
) {

Or have I missed something?

[RomaKis]

@dmanners, yes, you are right. It is fixed and squashed.

[dmanners]

@RomaKis There appears to be a small style problem.

There was 1 failure:
--
10-Nov-2017 05:50:34 | [exec]
10-Nov-2017 05:50:34 | [exec] 1) Magento\Test\Php\LiveCodeTest::testCodeStyle
10-Nov-2017 05:50:34 | [exec] PHP Code Sniffer detected 2 violation(s):
10-Nov-2017 05:50:34 | [exec]
10-Nov-2017 05:50:34 | [exec] FILE: ...to2/app/code/Magento/Catalog/Model/Category/Link/SaveHandler.php
10-Nov-2017 05:50:34 | [exec] ----------------------------------------------------------------------
10-Nov-2017 05:50:34 | [exec] FOUND 1 ERROR AFFECTING 1 LINE
10-Nov-2017 05:50:34 | [exec] ----------------------------------------------------------------------
10-Nov-2017 05:50:34 | [exec]  122 \| ERROR \| [x] Expected 0 spaces after opening bracket; newline
10-Nov-2017 05:50:34 | [exec]      \|       \|     found
10-Nov-2017 05:50:34 | [exec] ----------------------------------------------------------------------
10-Nov-2017 05:50:34 | [exec] PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
10-Nov-2017 05:50:34 | [exec] ----------------------------------------------------------------------

[RomaKis]

@dmanners, fixed.

[dmanners]

@RomaKis thanks

[testmagento2]

@dmanners, fixed