Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #10347 - Wrong order tax amounts displayed when using specific tax configuration (2.3-develop) #11594

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Fix issue #10347 - Wrong order tax amounts displayed when using specific tax configuration (2.3-develop) #11594

merged 1 commit into from
Nov 21, 2017

Conversation

PieterCappelle
Copy link
Contributor

Description

All information in this issue: #10347

Fixed Issues (if relevant)

  1. Wrong order tax amounts displayed when using specific tax configuration #10347

Manual testing scenarios

See issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@fooman
Copy link
Contributor

fooman commented Oct 21, 2017

@PieterCappelle Thanks for tackling this issue. That you were able to change the existing code without triggering any failures in the tests is unfortunately a sign that the existing test coverage in this area is not as good as it could be.

Would you be interested in adding some integration tests around this issue to ensure that your fix cannot be accidentally changed in the future?

@magento-engcom-team magento-engcom-team added 2.2.x bugfix Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 7, 2017
@okorshenko okorshenko merged commit 4aec05b into magento:2.3-develop Nov 21, 2017
okorshenko pushed a commit that referenced this pull request Nov 21, 2017
MAGETWO-83405: Fix issue #10347 - Wrong order tax amounts displayed w…
ff8d0f6 
…hen using specific tax configuration (2.3-develop) #11594
@PieterCappelle PieterCappelle deleted the fix_2_3_issue_10347 branch December 21, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
bugfix Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@PieterCappelle @fooman @magento-team @okorshenko @sidolov @magento-engcom-team