Add price calculation improvement for product option value price#11563
Merged
magento-team merged 2 commits intomagento:2.2-developfrom Dec 14, 2017
Merged
Add price calculation improvement for product option value price#11563magento-team merged 2 commits intomagento:2.2-developfrom
magento-team merged 2 commits intomagento:2.2-developfrom
Conversation
The price calculation relied on the getFinalPrice value, which if called without the qty parameter will not consider tier prices. This method was not updated when the price improvements have been added around 4 years ago. See similar update that was added for Magento\Catalog\Model\Product\Option. Resolves: magento#5774
dmanners
approved these changes
Dec 14, 2017
Contributor
|
Thank you for this PR @marinagociu I will get this processed through our QA team for you now. |
magento-team
pushed a commit
that referenced
this pull request
Dec 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The price calculation for the product option value relied on the getFinalPrice value, which if called without the qty parameter will not consider tier prices.
This method was updated to use the base price as calculated by the priceInfo object, just like in Magento\Catalog\Model\Product\Option.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist