Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7582: use setStoreId after custom load method to give storeId precedence #11165

Merged
merged 1 commit into from
Oct 11, 2017
Merged

#7582: use setStoreId after custom load method to give storeId precedence #11165

merged 1 commit into from
Oct 11, 2017

Conversation

bka
Copy link
Contributor

@bka bka commented Oct 1, 2017 •
edited by okorshenko
Loading

Description

I propose to change the order of of custom load method e.g. loadByCustomerId and setStoreId in Magento/Quote/Model/QuoteRepository::loadQuote to apply storeId.

Fixed Issues (if relevant)

  1. Payment methods in payments title in wrong language #7582: Payment methods in payments title in wrong language

Manual testing scenarios

  1. Have 2 Store Views with different languages e.g. EN and FR
  2. Change payment method title for FR
  3. Put some products into cart on EN store view
  4. Switch to FR store view
  5. Go to checkout payment methods
  6. Payment method will now be translated because storeId is applied after loading quote

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

magento#7582: use setStoreId after custom load method to given storeI…
33dcc36 
…d determination precedence to fix payment title translation error in checkout
@okorshenko okorshenko self-assigned this Oct 4, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 4, 2017
@okorshenko okorshenko merged commit 33dcc36 into magento:2.2-develop Oct 11, 2017
okorshenko pushed a commit that referenced this pull request Oct 11, 2017
MAGETWO-80894: #7582: use setStoreId after custom load method to give…
7255572 
… storeId precedence #11165
magento-engcom-team pushed a commit that referenced this pull request Aug 3, 2018
@viktym
MAGETWO-91330: [B2B] The product total price value on the second webs…
0fdd197 
…ite is as on the default website

- reverted fix from community PR #11165
- issue #7582 is fixed via plugin on store view switching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@bka @magento-team @okorshenko