Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vague error message for invalid url_key for category #11049

Merged

Conversation

avdb
Copy link

@avdb avdb commented Sep 26, 2017

Description

Problem: vague error message for invalid url_key for category
Example error message:
Invalid URL key

Solution: Use addFailedCategory() to add category to error message
Example error message:
1. Category " has not been created. Invalid URL key in row(s): 1

Fixed Issues (if relevant)

  1. Product Import: Additional data: Invalid URL key #10697: Product Import: Additional data: Invalid URL key

Manual testing scenarios

  1. System > Import > Products
  2. Choose "Add/Update
  3. Select a CSV file containing a "categories" column with a comma as the first character
  4. Click Check Data then Import

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

heyitsroberthe and others added 3 commits September 12, 2017 20:36
[mpi] MAGETWO-72551: Update version in composer to 2.2.1-dev for 2.2-develop branch
Error message for url_key is not wrong but too short
Use addFailedCategory() to add category to error message

Issue: 10697
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 29, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ avdb
❌ paliarush
❌ viktym

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants