-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable universal use of modal and tab_group #10789
Conversation
…nts which do not need to be validated
Hi @netzkollektiv |
I signed it several times, but I always get:
and it remains unsigned in github. Here's a basic example of a adding a new tab including a button and a modal to the customer form: |
To fix this you should add an email address used for the commit to your github account (may be private). Thank you |
I added the commit email to the netzkollektiv account (was part of my private acc), but it still does not work. What should I do? |
@ishakhsuvarov it needs to be the primary email - interesting. |
Wasn't aware of that, sorry. Thank you for the update. We will proceed with review and testing. |
…into netzkollektiv-develop
This pull request enables a universal use of modal and tab_group. In detail it allows having tab_group (used in customer edit view) to have child elements which do not need to be validated. Adding a construction like the "related products add"-functionality from catalog product edit via modal was not possible, because the modal inside the tab_group was tried to be validated as a field.
This change request ignores
undefined
elements in validation, but considersfalse
elements asfalse
andtrue
elements astrue
.Description
see above
Manual testing scenarios
undefined
error