Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification about deprecated methods in Abstract model #10211

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jul 11, 2017

Description

In Magento 2.1.x in Abstract model we have deprecated load, save and delete methods, but there are no clarification why it was deprecated and what we need to use instead. This pull requests brings changes from 5172132 to 2.1-develop branch.

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev ihor-sviziev changed the title Add comments in Abstract model to deprecated methods Add clarification about deprecated methods in Abstract model Jul 11, 2017
@okorshenko okorshenko self-assigned this Jul 11, 2017
@okorshenko okorshenko added this to the July 2017 milestone Jul 11, 2017
@magento-team magento-team merged commit 2be8fd7 into magento:2.1-develop Jul 11, 2017
@ihor-sviziev
Copy link
Contributor Author

@okorshenko is it possible to add these changes to 2.1.8? It doesn't have really changes, no functionality will be affected

@okorshenko
Copy link
Contributor

Hi @ihor-sviziev I will ping 2.1.8 team, but most likely it will go to next release after 2.1.8
There is no urgency in this changes and we are very close to 2.1.8 publication and code freeze
Anyway, thank you for your contribution. This is small but important comment 👍

@ihor-sviziev ihor-sviziev deleted the patch-4 branch October 5, 2017 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants