Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include attribute code in error message #10047

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Include attribute code in error message #10047

merged 1 commit into from
Jun 26, 2017

Conversation

lazyguru
Copy link
Contributor

@lazyguru lazyguru commented Jun 25, 2017

Description

The error message during import of a configurable product(s) is slightly vague if the configurable product(s) contain multiple super attributes

Manual testing scenarios

  1. Create an import file that would create a configurable product with more than one attribute set to be a super attribute (ensure that one of the attributes is not actually setup properly for use as a super attribute. eg type=text or attribute not included in attribute_set)
  2. Attempt to import the file

Before

Error message reads: Attribute with this code is not super in rows: 1, 2, 3...

After

Error message reads: Attribute with code "color" is not super in rows: 1, 2, 3...

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 26, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 26, 2017
@magento-team magento-team merged commit fb384f1 into magento:develop Jun 26, 2017
@lazyguru lazyguru deleted the better-error-message branch June 26, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants