Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better di generation error message #8709

Closed
spipu opened this issue Feb 28, 2017 · 2 comments
Closed

Better di generation error message #8709

spipu opened this issue Feb 28, 2017 · 2 comments
Assignees

Comments

@spipu
Copy link

spipu commented Feb 28, 2017

Hi,

I generate the di with the following command :

bin/magento setup:di:compile

If a error occurs, it display the reflexion error, but it does not give the name of the class that has the error.

Example: just change the asked type of a parameter of any constructor class to one type that does not exist, and launch the di compilation. You will have that kind of error:

[ReflectionException]                            
  Class Smile\Map\Model\Map\string does not exist  

The verbose mode does not help.

A good think could be to change this line:

https://github.com/magento/magento2/blob/2.1/lib/internal/Magento/Framework/Code/Reader/ClassReader.php#L36

by this one:

$message = $e->getMessage().' on ['.$className.']';

Regards,

Laurent

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

magento-team pushed a commit that referenced this issue Mar 8, 2017
 - Merge Pull Request #8768 from renatocason/magento2:hotfix/8709_di_exception_description
@okorshenko okorshenko reopened this Mar 9, 2017
@okorshenko
Copy link
Contributor

@spipu thank you for reporting the issue
@renatocason thank you for fixing this issue in PR: #8768

magento-devops-reposync-svc pushed a commit that referenced this issue Mar 5, 2024
ACPT-1718: Fixing: Application Server does not support session/cookie authorization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants