Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Minifying not compatible with CSS3 calc() function #8552

Closed
sydekumf opened this issue Feb 14, 2017 · 3 comments
Closed

CSS Minifying not compatible with CSS3 calc() function #8552

sydekumf opened this issue Feb 14, 2017 · 3 comments
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@sydekumf
Copy link

sydekumf commented Feb 14, 2017

Preconditions

  1. I use Magento 2.1.4 and the following extension: https://github.com/Magenerds/PageDesigner
  2. CSS Minifying and Merging is enabled in system configuration

Steps to reproduce

  1. Install the extension mentioned above OR inject your own CSS using calc(). You can see here the calc() css of the mentioned extension
  2. Open the site where this css gets rendered (for the extension it is a cms page in the backend)

Expected result

  1. The minified css should be calc((100% / 12 * 1) - 10px);

Actual result

  1. The minified css is instead calc((100%/12*1)- 10px); (no whitespaces) and therefore it will not be rendered correctly.
@sippsolutions
Copy link
Member

Can be reproduced. The magento minifying process seems to remove whitespace inside the calc()-statement.

@vrann vrann added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 13, 2017
@KrystynaKabannyk
Copy link

hello @sydekumf, thank you for the report, the internal ticket is created MAGETWO-66482.

@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development develop labels Jul 31, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-67487

magento-engcom-team pushed a commit that referenced this issue Jun 13, 2018
magento-devops-reposync-svc pushed a commit that referenced this issue Oct 13, 2023
…a2-develop

ACPT-1599: Fixing DeploymentConfig resets & reloads every time new key that wasn't previously set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants