Custom URL Rewrite where the request path ends with a forward slash is not matched

[hostep]

Preconditions

1. Magento CE 2.1.3
2. PHP 7.0.15

Steps to reproduce

1. Set up a clean Magento CE 2.1.3 store
2. In the admin, go to Marketing => URL Rewrites
3. Add a new Custom URL Rewrite like this:
   

Expected result

In the frontend, going to http://mydomain/test/ redirects you to http://mydomain/contact/

Actual result

In the frontend, going to http://mydomain/test/ gives you a 404 Not Found

Solution

Change the trim to ltrim in Magento\UrlRewrite\Controller\Router::getRewrite, otherwise the trailing slash will be removed and the url will never match.
(You need to flush your cache after changing this for some reason.)

Discussion

We want to import a bunch of custom redirects since we want to migrate an old custom build shop to magento 2 and we want to redirect using 301 headers from their old url structure to the new structure. The old structure uses a lot of url's with trailing slashes and this bug prevents it from redirecting properly to the new url structure. If we don't fix it, we would lose a bunch of Link Juice (SEO term) from the old url structure and that would very be bad.

Credits

Thanks to @LoganGS who discovered this bug and the solution over here: #6700

[miakusha]

Hi @hostep , thanks for report.
We've created internal ticket MAGETWO-64348 to address this issue.

[hostep]

@miakusha: ok if I close this issue, since it looks like this is a duplicate of #4876 and #7040, correct?

[vrann]

In order to make the complete fix next cases should be supported:

#	redirect	behaviour
1	"test" => "contact"	http://magento.loc/test/ => http://magento.loc/contact
2	"test" => "contact"	http://magento.loc/test => http://magento.loc/contact
3	"test/" => "contact/"	http://magento.loc/test/ => http://magento.loc/contact/
4	"test/" => "contact/"	http://magento.loc/test => http://magento.loc/contact/

[magento-team]

Internal ticket to track issue progress: MAGETWO-70255

[magento-team]

Internal ticket to track issue progress: MAGETWO-70505

[magento-engcom-team]

Fixed in 2.2.0 and 2.1 releases. @hostep thank you for report