Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running setup:backup with maintenance mode already on, disables after completion. #7951

Closed
spyrule opened this issue Dec 23, 2016 · 3 comments
Closed

Running setup:backup with maintenance mode already on, disables after completion. #7951

spyrule opened this issue Dec 23, 2016 · 3 comments
Labels
bug report Component: Setup Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@spyrule
Copy link

spyrule commented Dec 23, 2016

If you manually enable maintenance mode, then run setup:backup, when the backup is complete, it doesn't keep the maintenance mode on, it disables it automatically.

Preconditions

  1. Magento 2.1.3
  2. PHP 7
  3. nginx (hosted)

Steps to reproduce

  1. run > bin\magento maintenance:enable
  2. run > bin\magento setup:backup --db --code --media
  3. when backup is complete, you'll get:
    "[SUCCESS]: DB backup completed successfully.
    Disabling maintenance mode"

Expected result

  1. When the backup starts, it should check if maintenance mode is already enabled or not. If it is, it should NOT disable it when the backup is complete.

Actual result

  1. It disables the maintenance mode, regardless of its state prior to the backup being taken.
    error_1
@hostep hostep mentioned this issue Jun 12, 2017
Closed
@magento-engcom-team magento-engcom-team added 2.1.x bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Component: Setup labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 22, 2017
@magento-engcom-team
Copy link
Contributor

@spyrule, thank you for your report.
We've created internal ticket(s) MAGETWO-75973 to track progress on the issue.

@stevenvdp
Copy link
Contributor

I'll take a look at this one

stevenvdp added a commit to stevenvdp/magento2 that referenced this issue Sep 26, 2017
@stevenvdp
Do not disable maintenance mode after running a backup.
2cccbe4 
Keep the initial maintenance mode state before running the backup.
Only disable maintenance mode if it was not setted before.

Github issue: magento#7951
@stevenvdp stevenvdp mentioned this issue Sep 26, 2017
Merged
4 tasks
@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Sep 29, 2017
@okorshenko
Copy link
Contributor

The issue has been fixed by @stevenvdp in PR #11056 and will be available in 2.2.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Component: Setup Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@veloraven @stevenvdp @okorshenko @spyrule @ioliinyk @magento-engcom-team