Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI issue with bin/magento and exit codes for failure #7576

Closed
sitepodmatt opened this issue Nov 26, 2016 · 4 comments
Closed

CLI issue with bin/magento and exit codes for failure #7576

sitepodmatt opened this issue Nov 26, 2016 · 4 comments
Assignees
@misha-kotov
Labels
bug report Component: Setup Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@sitepodmatt
Copy link

sitepodmatt commented Nov 26, 2016 •
edited
Loading

Magento 2 CLI not setting expected/correct exit codes when an upgrade task fails.

Preconditions

Magento ~2.2 tip of develop

Steps to reproduce

Run a bin/magento setup:upgrade where a data upgrade fails, a simple die("lets hope this isnt tracked internally for the love of community but instead on github issues") in your modules UpgradeData.php upgrade function will suffice.

Expected result

Exit code should be non-zero

Actual result

Exit code is zero
@sitepodmatt
Copy link
Author

sitepodmatt commented Nov 26, 2016 •
edited
Loading

There exists a hacky workaround, I post to illustrate others are experiencing the same gripes, ultimately this shouldn't be necessary. http://aleron75.com/2016/08/12/magento2-script-for-setup-upgrade/

@sitepodmatt sitepodmatt changed the title CLI issue with bin/magento setup:upgrade CLI issue with bin/magento and exit codes for failure Nov 26, 2016
@shiftedreality
Copy link
Member

Hi @sitepodmatt

Thank you for your report.
I've created an internal ticket MAGETWO-61431 to resolve and fix this issue.

@shiftedreality shiftedreality added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 28, 2016
@choukalos
Copy link

Assigning to @misha-kotov .

magento-team pushed a commit that referenced this issue Apr 4, 2017
@shiftedreality
MAGETWO-61431: [GitHub] CLI issue with bin/magento and exit codes for…
0160b71 
… failure #7576
magento-team pushed a commit that referenced this issue Apr 4, 2017
@viktym
Merge pull request #995 from magento-falcons/MAGETWO-66853
c7ad941 
Fixed issues:
- MAGETWO-66736 Asymmetric transaction rollback error during stores importing
- MAGETWO-66672 Impossible generate fixture if store_groups>1
- MAGETWO-61431 [GitHub] CLI issue with bin/magento and exit codes for failure #7576
@veloraven
Copy link
Contributor

This issue has already been fixed.
Closed.

magento-devops-reposync-svc pushed a commit that referenced this issue Apr 20, 2022
@adifucan
Merge pull request #7576 from magento-performance/MCP-958-2
608507e 
[Performance] Speed up catalog permissions indexers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misha-kotov misha-kotov

Labels
bug report Component: Setup Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@choukalos @sitepodmatt @shiftedreality @veloraven @misha-kotov