-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bill-to Name and Ship-to Name trancated to 20 characters in backend #7279
Comments
Hi, thank you for your report. Internal ticket MAGETWO-61553 was created |
any progress on this? got a complaint today from a customer. it is not only affecting the backend, but also the transaction mails and our order export to the erp |
the reason for the truncating is that the mysql field definitions for |
Bill-to Name and Ship-to Name trancated to 20 characters in backend Compared the lengths of firstname, middlename and lastname of table "quote_address" with those of "quote" (255, 40 and 255 resp.) and of "sales_order_address" (255, 255 and 255) and with sales_order (128, 128 and 128) and choose to go with 255, 40 and 255 since these are used in "quote" as well and these are the values I know from Magento 1.9 as well. The other values are a bit inconsistent. Tested.
Bill-to Name and Ship-to Name trancated to 20 characters in backend Compared the lengths of firstname, middlename and lastname of table "quote_address" with those of "quote" (255, 40 and 255 resp.) and of "sales_order_address" (255, 255 and 255) and with sales_order (128, 128 and 128) and choose to go with 255, 40 and 255 since these are used in "quote" as well and these are the values I know from Magento 1.9 as well. The other values are a bit inconsistent. Tested. Updated setup version of the Quote module to 2.0.5, moved all updates into a single if statement.
Closing, as issue is fixed in the |
Reopening, as fix for |
I'm closing this issue as it was fixed in develop and there are no plans to fix it in ver. 2.1 or 2.0 for now. |
Hi @veloraven,
That sounds as if 2.1 and 2.0 branches are effectively abandoned and will only receive security fixes in the future. Can you confirm that starting from now there will is no support period for 2.1 planned whatsoever, despite the fact that 2.2 isn't even out yet? |
I've been expecting a stable version of Magento 2 for more than a year ((( |
@veloraven I'm curious as to why this is not being back-ported. Both 2.0 and 2.1 are still inside their support windows for bug fixes. This is a bug fix. Seems only logical that it should apply. |
@lazyguru @korostii Reopening again, since there is still no released version where the fix is available. Currently all the capacity of Magento teams working on 2.1 is busy with items of higher priority, so we can not provide information regarding the ETA for this fix. Thank you for collaboration |
Hi @ishakhsuvarov, thanks a lot for reopening the issue and for your informative response! |
Thanks @ishakhsuvarov! I think it is more than fair to ask for community to PR or be patient until you guys get to it. |
I have submitted a PR for backporting this to 2.1. I've started working on the 2.0 backport but it is complicated by an index update that happened in another commit. I'm trying to track down where that happened to see what the best way to approach this might be. However, since 2.0 is EOL in November, it may not be as relevant to backport this fix to it? (not sure if there is demand for it) |
Hi @lazyguru |
Let me clarify, 2.0 is still supported. But it will be EOL according to the schedule in November |
Internal ticket to track issue progress: MAGETWO-69230 |
Internal ticket to track issue progress: MAGETWO-70077 |
I think something went wrong here. It's a bit strange seeing both Thanks in advance. |
@korostii
while Basically, this issue seems to be fixed in latest |
Let me rephrase my point: Gate1 is buggy and it shouldn't even touch the issues which are already This exact issue is lucky to be fixed already, but it would be most unfortunate to get some other acknowledged issue like it filter out for the same reason. |
@korostii ok, got your point now. I didn't check the workflow changes details yet, but to me it looks like |
Preconditions
Magento ver. 2.1.2
php version 7.0, MariaDB 10.1
Steps to reproduce
Input firstname longer than 20 characters on Checkout shipping step
Actual result
Go to backend Sales-Orders and check Bill-to Name and Ship-to Name. Both names trancated to 20 characters!
The text was updated successfully, but these errors were encountered: