Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Idea: /var/cache/mage--X #687

Closed
gstaniforthsessiondigital opened this issue Oct 10, 2014 · 6 comments
Closed

Improvement Idea: /var/cache/mage--X #687

gstaniforthsessiondigital opened this issue Oct 10, 2014 · 6 comments
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@gstaniforthsessiondigital

Instead of storing cache in a serialised array it would be much faster to store it as a native php file and var_export() the array.

If the file is .php it will get picked up via the opcache and be stored in memory but also precompiled and stored in opcache. This would also remove unserialised logic also.

@verklov verklov self-assigned this Nov 8, 2014
@verklov
Copy link
Contributor

verklov commented Nov 8, 2014

@gstaniforthsessiondigital, thank you for your suggestion! Our architects will review it and we will then let you know of the investigation results.

@aohorodnyk
Copy link
Contributor

Hello,

For improvement some users can disable check for updated scripts (php files) in opcache for performance improvement. Magento does not know about opcache engines on server. Magento need support all opcache applications (xcache, php opcache, apc and etc.) or use scripts for serializations deserializations

Thanks

@maksek maksek added the TECH label Jan 8, 2015
@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-30482

@vpelipenko
Copy link
Contributor

@gstaniforthsessiondigital, did you have a chance to look at last comment here posted by @aohorodnyk?

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update labels Mar 25, 2015
@orlangur
Copy link
Contributor

@aohorodnyk,

For improvement some users can disable check for updated scripts (php files) in opcache for performance improvement. Magento does not know about opcache engines on server. Magento need support all opcache applications (xcache, php opcache, apc and etc.) or use scripts for serializations deserializations

"support all opcache applications" is not relevant for PHP 5.5+. Also, if check for updated PHP files is not disabled on production - it's simply a server misconfiguration which must be fixed.

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

magento-engcom-team pushed a commit that referenced this issue Jun 21, 2019
magento-engcom-team added a commit that referenced this issue Jun 21, 2019
 - Merge Pull Request magento/graphql-ce#749 from magento/graphql-ce:687-Redundant-isset
 - Merged commits:
   1. aeec8f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants