Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'select' to 'query' in AbstractSearchResult #5040

Closed
flancer64 opened this issue Jun 15, 2016 · 2 comments
Closed

Change 'select' to 'query' in AbstractSearchResult #5040

flancer64 opened this issue Jun 15, 2016 · 2 comments
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@flancer64
Copy link
Contributor

Hello,

there is protected property "select" in AbstractSearchResult that is never used

/**
 * @var \Magento\Framework\DB\Select
 */
protected $select;

... and there is 'query' property in the constructor that is not defined:

public function __construct(
    \Magento\Framework\DB\QueryInterface $query,
    ...
) {
    $this->query = $query;
    ...
}

I suppose this code:

/**
 * @var \Magento\Framework\DB\Query
 */
protected $query;

should be instead of 'select' property.

@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-67408

@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development develop improvement labels Jul 31, 2017
magento-team pushed a commit that referenced this issue Jan 28, 2020
…fix-2

[Magento Community Engineering] Adobe Stock Integration Bug Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

6 participants