Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "contacts" module to just "contact" #504

Closed
brendanfalkowski opened this issue Feb 12, 2014 · 7 comments
Closed

Rename "contacts" module to just "contact" #504

brendanfalkowski opened this issue Feb 12, 2014 · 7 comments
Assignees
@elenleonova
Labels
improvement

Comments

@brendanfalkowski
Copy link
Contributor

For virtually any type of site, having http://domain.com/contact is a standard URL pattern for contact info. Only in Magento is this URL named "/contacts" instead.

This is an annoying carryover from Magento 1. You can add two URL rewrites to get around it, but that shouldn't continue to be necessary. It'd be a smarter default to have this URL available as "/contact".
@philwinkle
Copy link
Contributor

Or configurable without url rewrites...

On Wed, Feb 12, 2014 at 6:20 PM, Brendan Falkowski <[email protected]

wrote:

For virtually any type of site having http://domain.com/contact is kind
of a standard.

Only in Magento is this URL named "/contacts" instead. This is an annoying
carryover from Magento 1. Yes, you can add two URL rewrites to get around
it but that's annoying to do on every site.

It'd be a smarter default to have this URL available at "/contact".

Reply to this email directly or view it on GitHubhttps://github.com//issues/504
.

Follow me on Twitter - @philwinkle
Friend me on Facebook - http://www.facebook.com/philwinkle

@davidalger
Copy link
Member

👍

2 similar comments
@ghost
Copy link

ghost commented Feb 13, 2014

👍

@ArnaudLigny
Copy link

👍

@verklov verklov self-assigned this Feb 14, 2014
@aoldoni
Copy link
Contributor

aoldoni commented Feb 18, 2014

👍

@verklov verklov assigned elenleonova and unassigned verklov Feb 24, 2014
@verklov
Copy link
Contributor

verklov commented Feb 24, 2014

Reassigning to @eleonova who would be able to better respond to this issue.

magento-team added a commit that referenced this issue Apr 11, 2014
@magento-team
2.0.0.0-dev73
8611ea7 
* Framework Improvements:
  * Eliminated the StoreConfig class, and ability to work with Configuration through the Store object. Scope Config was introduced instead.
  * Fixed performance degradation caused by DI argument processors
  * Covered Magento library components with unit tests:
     * Magento/App/Request
     * Magento/App/Resource directory and Magento/App/Resource.php
     * Magento/App/Response
     * Magento/App/Route
     * Magento/App/Router
     * Magento/App/Http.php
     * Magento/Translate.php
  * Improved the Web API framework based on Customer Service
  * Updated the API Service Exception Handling
  * Changed the conventional notation of Vendor name in theme path: from `app/design/<area>/<vendor>_<theme>` to `app/design/<area>/<vendor>/<theme>`
  * Renamed the 3DSecure library to CardinalCommerce, and removed the unused flex library
* Themes update:
  * Updated the look&feel of the Admin theme
* Modularity improvements:
  * Introduced a new Store module. Moved all Store related logic from Magento_Core to Magento_Store
  * Moved the library part of the Config component from the Magento_Core module to the library
  * Moved the Session related logic from the Magento_Core module to the library
  * Moved the abstract logic related to Magento "Module" from Magento_Core to the library
  * Moved the form key related functionality to the library
  * Introduced a new Magento_UrlRewrite module and moved related classes from Magento_Core to the new module
  * Moved the resource model to Magento_Install module
  * Eliminated the Core\Helper\Js class
  * Moved the Email related logic from Magento_Core module to Magento_Email module
  * Moved the Cache related logic from the Magento_Core module to the library
  * Resolved issues which appeared when an order had been placed before the Magento_Payment module was disabled
  * Eliminated Magento_Catalog dependency on Magento_Rating
  * Removed the Magento_Rating module, its logic moved to Magento_Review
  * Moved the View related components from Magento_Core to the Magento/View library
* Refactored the following modules to use Customer Service
  * Magento_Multishipping
  * Magento_Paypal
  * Magento_Log
  * Magento_RSS
  * Magento_Review
  * Magento_Wishlist
  * Magento_Weee
  * Magento_CatalogInventory
  * Magento_CatalogRule
  * Magento_SalesRule
* GitHub requests:
  * [#520] (#520) -- Fixed spelling in Magento\Payment\Model\Method\AbstractMethod
  * [#481] (#481) -- GD2 Adapter PHP memory_limit
  * [#516] (#516) -- Make Sure That save_before Event Is Dispatched
  * [#465] (#465) -- Absolute path is assembled incorrectly when merging js/css files
  * [#504] (#504) -- Renamed "contacts" module to "contact"
  * [#529] (#529) -- Fixed exception at admin dashboard
  * [#535] (#535) -- Fixed an issue during creating or editing product template
  * [#535] (#535) -- Fixed Typo in the module name
  * [#538] (#538) -- Fixed missing tax amount in the invoice
  * [#518] (#518) -- Change to Magento\Customer\Block\Widget\Dob new version
* Fixed bugs:
  * Fixed implementation issues with Cron task group threading
  * Fixed inability to place order during customer registration flow
  * Fixed an issue where after JS minification errors appeared when loading pages which contained minified JS
  * Fixed an issue where it was impossible for users with restricted permission to export certain entities
  * Fixed an issue where checkout was blocked by the "Please enter the State/Province" pop-up for customers that had saved addresses
  * Fixed an issue where a fatal error appeared when trying to check out the second time with OnePageCheckout
  * Fixed an issue where a fatal error appeared when trying to create an online invoice for an order placed with PayPal Express Checkout (Payment Action = Order)
  * Fixed an issue where the special price for a bundle product was calculated wrongly
  * Fixed an issue where a fatal error appeared when trying to create a shipment for an order if Magento was installed without the USPS module
  * Fixed an issue where the Lifetime Sales and Average Orders sections of the Admin Dashboard were missing
  * Fixed an issue where the active tab changed after changing the attribute set
  * Fixed an issue with incorrect order of product types in the Add Product menu in the backend
  * Fixed an issue with saving the tier price attribute
* JavaScript improvements:
  * Upgraded the frontend jQuery library to version 1.11
  * Upgraded the frontend jQuery UI library to version 1.10.4
  * Modified the loader widget to render content using handlebars
  * Added the 'use strict' mode to the accordion widget
  * Added the 'use strict' mode to the tab widget
@verklov
Copy link
Contributor

verklov commented Apr 11, 2014

@brendanf, we have fixed this issue. The code has just been released in dev73. Thank you for reporting it to us!

@verklov verklov closed this as completed Apr 11, 2014
magento-team pushed a commit that referenced this issue Aug 6, 2015
Merge pull request #504 from magento-firedrakes/MAGETWO-39265
04c2e63 
[Firedrakes] Code Improvements in Sales module MAGETWO-39265
magento-team pushed a commit that referenced this issue Apr 2, 2016
@mazhalai
Merge pull request #504 from magento-ogre/PR_Branch
1f7a63d 
[Ogres] Bug fixes
mmansoor-magento pushed a commit that referenced this issue Oct 20, 2016
@rganin
Merge pull request #504 from magento-troll/sprint21
0c6227d 
MAGETWO-51655 [Improvement] Convert customer group identifier field from SMALLINT to INT
magento-engcom-team added a commit to okorshenko/magento2 that referenced this issue May 10, 2019
@magento-engcom-team
ENGCOM-5027: GraphQl-309: [Checkout] Checkout Agreements magento#504
5c32883 
 - Merge Pull Request magento/graphql-ce#504 from magento/graphql-ce:graphQl-309-checkout-agreement-coverage
 - Merged commits:
   1. 17b7c0a
   2. d3190fe
   3. 4faf980
   4. f17893d
   5. 6a8c89b
   6. f90a620
   7. 6b93033
   8. cc5e217
   9. c94a655
   10. d82262c
   11. 7305a43
   12. 6a8edac
   13. c3040e6
   14. c1c1dc0
   15. 4d7be93
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue May 10, 2019
@naydav
ENGCOM-5027: GraphQl-309: [Checkout] Checkout Agreements magento#504
2aeb977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elenleonova elenleonova

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ArnaudLigny @brendanfalkowski @philwinkle @davidalger @aoldoni @elenleonova @verklov