Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order view grid selection is missing order scope #3895

Closed
AntonEvers opened this issue Mar 25, 2016 · 1 comment
Closed

Order view grid selection is missing order scope #3895

AntonEvers opened this issue Mar 25, 2016 · 1 comment
Assignees

Comments

@AntonEvers
Copy link
Contributor

When you select all invoices of one order in the order detail page of the admin and apply a mass action to it, the mass action is applied on all invoices in the whole system. This is because the context of the order_id gets lost in the mass action.

vendor/magento/module-sales/view/adminhtml/ui_component/sales_order_view_invoice_grid.xml:

                    <item name="filter_url_params" xsi:type="array">
                        <item name="order_id" xsi:type="string">*</item>
                    </item>

This part of the code would filter only invoices of this order_id, but the order_id param is absent in the mass action POST/GET:

Request: http://magento2.dev/sitemanager/sales/invoice/pdfinvoices/key/57643a9c1297d88c9998a26eb46af31d1f36540631c3f81a4a231564f70ecfff/

Request payload:

------WebKitFormBoundary776fKNJgSVASkucJ
Content-Disposition: form-data; name="excluded"

false
------WebKitFormBoundary776fKNJgSVASkucJ
Content-Disposition: form-data; name="filters[placeholder]"

true
------WebKitFormBoundary776fKNJgSVASkucJ
Content-Disposition: form-data; name="search"


------WebKitFormBoundary776fKNJgSVASkucJ
Content-Disposition: form-data; name="namespace"

sales_order_view_invoice_grid
------WebKitFormBoundary776fKNJgSVASkucJ
Content-Disposition: form-data; name="form_key"

Ta4dxuMGnvF5q04Y
------WebKitFormBoundary776fKNJgSVASkucJ--
Name

To replicate this, open an order, go to invoices, select all and choose the Export PDF mass action:

screen shot 2016-03-24 at 10 32 22

screen shot 2016-03-24 at 10 32 52

invoice2016-03-24_09-32-57.pdf

@NadiyaS
Copy link
Contributor

NadiyaS commented Jun 8, 2016

Hi @ajpevers ,
Fix has been delivered to develop branch 23d12c9.
You can upgrade your code from develop branch or wait until next release.
Issue is closed as resolved.
Feel free to reopen this issue is you have encountered the same problem on upgraded version.

@NadiyaS NadiyaS closed this as completed Jun 8, 2016
magento-engcom-team pushed a commit that referenced this issue Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants