Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error review when customer is not logged #3791

Closed
quienti opened this issue Mar 15, 2016 · 3 comments
Closed

Error review when customer is not logged #3791

quienti opened this issue Mar 15, 2016 · 3 comments
Labels
bug report Component: Customer Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@quienti
Copy link
Contributor

quienti commented Mar 15, 2016

Steps to reproduce

  1. Magento 2.0.2
  2. Config -> Allow Guests to Write Reviews -> No
    sans titre 1
  3. Loggin in frontend
  4. Go to any product page with review
  5. Wait logout without refresh page
  6. Post a review

Expected result

  1. You need to log to post a review

Actual result

Report error

a:4:{i:0;s:181:"Notice: Undefined property: Magento\Review\Controller\Product\Post\Interceptor::$_reviewSession in /home/magento2/www/vendor/magento/module-review/Controller/Product.php on line 158";i:1;s:10084:"#0 /home/magento2/www/vendor/magento/module-review/Controller/Product.php(158): Magento\Framework\App\ErrorHandler->handler(8, 'Undefined prope...', '/home/magento2/...', 158, Array) #1 [internal function]: Magento\Review\Controller\Product->dispatch(Object(Magento\Framework\App\Request\Http)) #2 /home/magento2/www/vendor/magento/framework/Interception/Interceptor.php(74): call_user_func_array(Array, Array) #3 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(70): Magento\Review\Controller\Product\Post\Interceptor->___callParent('dispatch', Array) #4 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Review\...', 'dispatch', Object(Magento\Review\Controller\Product\Post\Interceptor), Array, 'designLoader') #5 /home/magento2/www/vendor/magento/framework/App/Action/Plugin/Design.php(39): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http)) #6 [internal function]: Magento\Framework\App\Action\Plugin\Design->aroundDispatch(Object(Magento\Review\Controller\Product\Post\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #7 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(68): call_user_func_array(Array, Array) #8 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Review\...', 'dispatch', Object(Magento\Review\Controller\Product\Post\Interceptor), Array, 'contextPlugin') #9 /home/magento2/www/vendor/magento/module-store/App/Action/Plugin/Context.php(98): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http)) #10 [internal function]: Magento\Store\App\Action\Plugin\Context->aroundDispatch(Object(Magento\Review\Controller\Product\Post\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #11 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(68): call_user_func_array(Array, Array) #12 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Review\...', 'dispatch', Object(Magento\Review\Controller\Product\Post\Interceptor), Array, 'storeCheck') #13 /home/magento2/www/vendor/magento/module-store/App/Action/Plugin/StoreCheck.php(44): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http)) #14 [internal function]: Magento\Store\App\Action\Plugin\StoreCheck->aroundDispatch(Object(Magento\Review\Controller\Product\Post\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #15 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(68): call_user_func_array(Array, Array) #16 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Review\...', 'dispatch', Object(Magento\Review\Controller\Product\Post\Interceptor), Array, 'customer-app-ac...') #17 /home/magento2/www/vendor/magento/module-customer/Model/App/Action/ContextPlugin.php(61): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http)) #18 [internal function]: Magento\Customer\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Review\Controller\Product\Post\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #19 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(68): call_user_func_array(Array, Array) #20 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Review\...', 'dispatch', Object(Magento\Review\Controller\Product\Post\Interceptor), Array, 'tax-app-action-...') #21 /home/magento2/www/vendor/magento/module-tax/Model/App/Action/ContextPlugin.php(91): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http)) #22 [internal function]: Magento\Tax\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Review\Controller\Product\Post\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #23 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(68): call_user_func_array(Array, Array) #24 /home/magento2/www/vendor/magento/framework/Interception/Interceptor.php(136): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Review\...', 'dispatch', Object(Magento\Review\Controller\Product\Post\Interceptor), Array, 'weee-app-action...') #25 /home/magento2/www/vendor/magento/module-weee/Model/App/Action/ContextPlugin.php(112): Magento\Review\Controller\Product\Post\Interceptor->Magento\Framework\Interception{closure}(Object(Magento\Framework\App\Request\Http)) #26 [internal function]: Magento\Weee\Model\App\Action\ContextPlugin->aroundDispatch(Object(Magento\Review\Controller\Product\Post\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #27 /home/magento2/www/vendor/magento/framework/Interception/Interceptor.php(141): call_user_func_array(Array, Array) #28 /home/magento2/www/var/generation/Magento/Review/Controller/Product/Post/Interceptor.php(39): Magento\Review\Controller\Product\Post\Interceptor->___callPlugins('dispatch', Array, Array) #29 /home/magento2/www/vendor/magento/framework/App/FrontController.php(55): Magento\Review\Controller\Product\Post\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http)) #30 [internal function]: Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http)) #31 /home/magento2/www/vendor/magento/framework/Interception/Interceptor.php(74): call_user_func_array(Array, Array) #32 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(70): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array) #33 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'requestPreproce...') #34 /home/magento2/www/vendor/magento/module-store/App/FrontController/Plugin/RequestPreprocessor.php(89): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http)) #35 [internal function]: Magento\Store\App\FrontController\Plugin\RequestPreprocessor->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #36 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(68): call_user_func_array(Array, Array) #37 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'install') #38 /home/magento2/www/vendor/magento/framework/Module/Plugin/DbStatusValidator.php(69): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http)) #39 [internal function]: Magento\Framework\Module\Plugin\DbStatusValidator->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #40 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(68): call_user_func_array(Array, Array) #41 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(63): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'front-controlle...') #42 /home/magento2/www/vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php(73): Magento\Framework\Interception\Chain\Chain->Magento\Framework\Interception\Chain{closure}(Object(Magento\Framework\App\Request\Http)) #43 [internal function]: Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #44 /home/magento2/www/vendor/magento/framework/Interception/Chain/Chain.php(68): call_user_func_array(Array, Array) #45 /home/magento2/www/vendor/magento/framework/Interception/Interceptor.php(136): Magento\Framework\Interception\Chain\Chain->invokeNext('Magento\Framewo...', 'dispatch', Object(Magento\Framework\App\FrontController\Interceptor), Array, 'front-controlle...') #46 /home/magento2/www/vendor/magento/module-page-cache/Model/App/FrontController/VarnishPlugin.php(55): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception{closure}(Object(Magento\Framework\App\Request\Http)) #47 [internal function]: Magento\PageCache\Model\App\FrontController\VarnishPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http)) #48 /home/magento2/www/vendor/magento/framework/Interception/Interceptor.php(141): call_user_func_array(Array, Array) #49 /home/magento2/www/var/generation/Magento/Framework/App/FrontController/Interceptor.php(26): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, Array) #50 /home/magento2/www/vendor/magento/framework/App/Http.php(115): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http)) #51 /home/magento2/www/vendor/magento/framework/App/Bootstrap.php(258): Magento\Framework\App\Http->launch() #52 /home/magento2/www/index.php(39): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http)) #53 {main}";s:3:"url";s:29:"/review/product/post/id/1102/";s:11:"script_name";s:10:"/index.php";}

@piotrekkaminski
Copy link
Contributor

Internal issue MAGETWO-54352

@vkorotun vkorotun removed the MX label Aug 4, 2016
@veloraven veloraven added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Aug 16, 2016
@korostii
Copy link
Contributor

korostii commented Mar 2, 2017

This is just embarrassing.

Fixing this is literally as simple as removing one symbol (namely the underscore) here

It's incomprehensible how fixing something like that could drag on for years.

@quienti quienti mentioned this issue Mar 24, 2017
magento-team pushed a commit that referenced this issue Mar 25, 2017
@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Customer develop labels Jul 31, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-66694

magento-engcom-team pushed a commit that referenced this issue Feb 21, 2019
[EngCom] Public Pull Requests - GraphQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Customer Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

8 participants