-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper Test Cases for Configurable/Simple Products #346
Comments
Just as an update on this...... Looking at the 2500 configurable product creation code: It looks like you are only generating 2 options for your testing, "Option 1" and "Option 2". Therefore, in things like "function _loadPrices()", this call "$options = $productAttribute->getFrontend()->getSelectOptions();" only ever returns 2 items to loop through with your configurable product tests. I'm not sure what a good average is for options, but I know we currently have 4,500+. Since this is often looped through, that can be quite a difference depending on what happens in the following loop. I wouldn't suggest just adding in 4,000 options into that script (since it will cause your 5,000 simple products to turn into 10,000,000 simple products) but something should be tweaked with that testing setup as 2 options can't be representative of most installs. |
Thank you for proposal. Internal reference: MAGETWO-33574 |
[Extensibility] MAGETWO-48590: Failing Travis builds
Moving 33574 under performance measurement epic 53797. @fr0x In our market research we identified the average e-commerce site having 3 product options for configurable & bundled products. We are currently using that when generating test fixtures with the performance tool kit. The epic 53797 is intended to provide more generation control for test fixtures to address # of product options and # of super attributes that manage those permutations. |
Now fixture for configurable product support any number of variation, so I close issue |
Fixed issues: - MAGETWO-57338: [Backport] - Customer is not redirected to checkout on login if guest is disabled - for 2.0 - MAGETWO-57513: [Backport] - Giftcard Purchase - Order Status - Processing - for 2.0 - MAGETWO-57844: [Backport] - [Github # 6294] Coupon code override cart rules with no coupon code - for 2.0
- Merge Pull Request magento/graphql-ce#346 from sergiy-v/graphql-ce:250_configurable_options_label - Merged commits: 1. 2b4d501 2. fd83649
I've seen a few patches in regards to configurable products closed due to insufficient gains in load time in your unit testing.
You mentioned this setup in testing:
I assume that is then 5000 individual simple products (2 unique simple products per configurable product)? What were the number of unique super attributes for those simple products? Some of these changes are in large part dependent on the number of super attributes returned. If you only had 2 super attributes defined for those 5000 simple products (black and white) as opposed to multiple thousands (red, pink, cherry, rose, sunset, and on and on.....) these changes pan out quite a bit differently.
See Issue #293
#293
The text was updated successfully, but these errors were encountered: