Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Test Cases for Configurable/Simple Products #346

Closed
fr0x opened this issue Aug 27, 2013 · 4 comments
Closed

Proper Test Cases for Configurable/Simple Products #346

fr0x opened this issue Aug 27, 2013 · 4 comments
Assignees
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@fr0x
Copy link

fr0x commented Aug 27, 2013

I've seen a few patches in regards to configurable products closed due to insufficient gains in load time in your unit testing.

You mentioned this setup in testing:

  • Magento CE 1.7.0.1 with clear DB
  • 2500 configurable products with 2 simple products as options per each configurable product

I assume that is then 5000 individual simple products (2 unique simple products per configurable product)? What were the number of unique super attributes for those simple products? Some of these changes are in large part dependent on the number of super attributes returned. If you only had 2 super attributes defined for those 5000 simple products (black and white) as opposed to multiple thousands (red, pink, cherry, rose, sunset, and on and on.....) these changes pan out quite a bit differently.

See Issue #293
#293

@fr0x
Copy link
Author

fr0x commented May 16, 2014

Just as an update on this......

Looking at the 2500 configurable product creation code:
https://gist.github.com/mage2-team/4040304

It looks like you are only generating 2 options for your testing, "Option 1" and "Option 2".

Therefore, in things like "function _loadPrices()", this call "$options = $productAttribute->getFrontend()->getSelectOptions();" only ever returns 2 items to loop through with your configurable product tests. I'm not sure what a good average is for options, but I know we currently have 4,500+. Since this is often looped through, that can be quite a difference depending on what happens in the following loop.

I wouldn't suggest just adding in 4,000 options into that script (since it will cause your 5,000 simple products to turn into 10,000,000 simple products) but something should be tweaked with that testing setup as 2 options can't be representative of most installs.

@kokoc
Copy link
Member

kokoc commented Feb 3, 2015

Thank you for proposal.
We will get back to you once we have the solution or answer.

Internal reference: MAGETWO-33574

@vpelipenko vpelipenko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development PROD and removed TECH labels Feb 17, 2015
magento-team pushed a commit that referenced this issue Jun 12, 2015
magento-team pushed a commit that referenced this issue Feb 2, 2016
[Extensibility] MAGETWO-48590: Failing Travis builds
@choukalos
Copy link

Moving 33574 under performance measurement epic 53797.

@fr0x In our market research we identified the average e-commerce site having 3 product options for configurable & bundled products. We are currently using that when generating test fixtures with the performance tool kit. The epic 53797 is intended to provide more generation control for test fixtures to address # of product options and # of super attributes that manage those permutations.

@vkorotun vkorotun removed the MX label Aug 4, 2016
@kandy
Copy link
Contributor

kandy commented Aug 15, 2016

Now fixture for configurable product support any number of variation, so I close issue

@kandy kandy closed this as completed Aug 15, 2016
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Fixed issues:
- MAGETWO-57338: [Backport] - Customer is not redirected to checkout on login if guest is disabled - for 2.0
- MAGETWO-57513: [Backport] - Giftcard Purchase - Order Status - Processing - for 2.0
- MAGETWO-57844: [Backport] - [Github # 6294] Coupon code override cart rules with no coupon code - for 2.0
magento-engcom-team added a commit that referenced this issue Feb 11, 2019
 - Merge Pull Request magento/graphql-ce#346 from sergiy-v/graphql-ce:250_configurable_options_label
 - Merged commits:
   1. 2b4d501
   2. fd83649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

8 participants