Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mage_Shipping_Model_Resource_Carrier_Tablerate::uploadAndImport reads from $_FILES #242

Closed
amenk opened this issue Feb 21, 2013 · 4 comments
Closed

Mage_Shipping_Model_Resource_Carrier_Tablerate::uploadAndImport reads from $_FILES #242

amenk opened this issue Feb 21, 2013 · 4 comments

Comments

@amenk
Copy link
Contributor

amenk commented Feb 21, 2013

I think this method should not read from $_FILES. This is not a clear separation in the code. Instead it should be passed the filename directly.

https://github.com/magento/magento2/blob/master/app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php#L187
@magento-team
Copy link
Contributor

Hello. Would you be able to contribute this is a pull request? There are also existing uploader classes that you might be able to reuse

@amenk
Copy link
Contributor Author

amenk commented Feb 22, 2013

If I find some time, yes... Which are the uploader classes are you talking about?

@nevvermind
Copy link
Contributor

@amenk - I think they're referring to Varien_File_Uploader.

@magento-team
Copy link
Contributor

Closing due to lack of activity. Please comment if you think you might be able to contribute a pull request.

magento-team pushed a commit that referenced this issue Apr 24, 2015
Merge pull request #242 from magento-folks/bugs
c316821 
[Folks] Bugfix
mazhalai added a commit that referenced this issue Dec 17, 2015
@mazhalai
Merge pull request #242 from magento-api/Sprint-59-PR
648ce10 
[API] Sprint 59
mmansoor-magento pushed a commit that referenced this issue Aug 15, 2016
@MomotenkoNatalia
Merge pull request #242 from magento-mpi/MPI-PR
903dcbb 
Stories:
- MAGETWO-51658 Kount Status
- MAGETWO-54499 PayPal Payments Configuration UX Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nevvermind @amenk @magento-team