Can't cancel removal of a block or container in layout by setting remove attribute value to false #1931

thomasnordkvist · 2015-09-23T07:48:27Z

I inherit the blank theme and i wanted to have the top.links visible in the checkout so i created this file:

Vendor/Theme/Magento_Checkout/layout/checkout_index_index.xml
containing this:

<?xml version="1.0"?>
<!--
/**
 * Copyright © 2015 Magento. All rights reserved.
 * See COPYING.txt for license details.
 */
-->
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="2columns-left" xsi:noNamespaceSchemaLocation="../../../../../../../lib/internal/Magento/Framework/View/Layout/etc/page_configuration.xsd">
    <body>
        <referenceContainer name="header.panel" remove="false"/>
    </body>
</page>

Reading This i understand, that it sould now be possible to cancel a removal instruction with the above instruction, but it doesn't seem to work.

I know the file is parsed, and included in the layout, because if i add a block from this file it will show up on the checkout page.

/Thomas

The text was updated successfully, but these errors were encountered:

daim2k5 · 2015-11-10T08:55:37Z

The GitHub issue tracker is intended for technical issues only. Please refer to the Community Forums or Magento Stack Exchange site for technical questions. In your case, the programming questions forum is likely the most appropriate. Feel free to reopen this issue if you think you have encountered a bug in Magento 2.

philippsander · 2016-03-16T14:42:56Z

this sounds like a technical issue for me... I have the same problem.

EDIT: the documentation clearly says the the removeal process is canceled. that does not work!

thomasnordkvist · 2016-03-16T17:16:52Z

I had almost forgotten this issue.
It should be reopened as a bug.

I did some copy paste to build up the parts i wanted back in the header.

AntonEvers · 2016-05-26T13:30:10Z

This problem can be reproduced by removing an element in a parent theme and trying to cancel it in a child theme.

BenSpace48 · 2016-06-01T11:28:44Z

Any news on this yet Magento? It doesn't even look it's been been internally raised or acknowledged yet.

CC @daim2k5

dexterchua19 · 2016-06-09T03:33:29Z

Any news about this? I'm developing a website and this same problem occurs in me.

pboisvert · 2016-06-30T19:00:34Z

@tkacheva can you ask the team to investigate this one?

tkacheva · 2016-07-01T09:42:02Z

@eug123 please take a look MAGETWO-54935

philippsander · 2016-07-07T12:00:23Z

come on guys. almost 4 months to fix this?

tkacheva · 2016-07-08T11:01:37Z

@philippsander issue is waiting to be merged

Styopchik · 2016-07-22T07:01:12Z

Still waiting

…uts doesn't work -- integration test

Fixed issues: - MAGETWO-57432: Functional test Magento\Bundle\Test\TestCase\CreateBundleProductEntityTest is failed - MAGETWO-55510: "Client side less compilation" does not work properly #3325 - MAGETWO-54935: [Github #1931] Cancellation of element removal in layouts doesn't work

torreytsui · 2016-11-24T11:53:00Z

A limited workaround for the time being

If the purpose is simply hiding and displaying specific blocks and if you have full control on those layouts, you may interest in this limited workaround.

<!-- parent_layout_handle.xml -->
+ <referenceContainer name="root" display="false"/>
- <referenceContainer name="root" remove="true"/>

<!-- child_layout_handle.xml -->
+ <referenceContainer name="root" display="true"/>
- <referenceContainer name="root" remove="false"/>

Use display instead of remove. This workaround is very limited as we don't usually have full controls on all layout. For example, many Magento vanilla handles have remove="true" instructions and we basically cannot add those blocks back before a fix is released.

`remove="false"` seems not implemented

If you do need the remove="false" to work before a fix is released, there is a way of hacking.

// \Magento\Framework\View\Layout\Reader\Block::scheduleReference
protected function scheduleReference(
        Layout\ScheduledStructure $scheduledStructure,
        Layout\Element $currentElement
    ) {
        $elementName = $currentElement->getAttribute('name');
        $elementRemove = filter_var($currentElement->getAttribute('remove'), FILTER_VALIDATE_BOOLEAN);
        if ($elementRemove) {
            $scheduledStructure->setElementToRemoveList($elementName);
        } else {
            $data = $scheduledStructure->getStructureElementData($elementName, []);
            $data['attributes'] = $this->mergeBlockAttributes($data, $currentElement);
            $this->updateScheduledData($currentElement, $data);
            $this->evaluateArguments($currentElement, $data);
            $scheduledStructure->setStructureElementData($elementName, $data);
        }
    }

I suppose $scheduledStructre->unsetElementFromListToRemove($elementName) should be called in the else condition or something relevant so that the remove flag of the block will be reset and the block can be kept.

        if ($elementRemove) {
            $scheduledStructure->setElementToRemoveList($elementName);
        } else {
            $data = $scheduledStructure->getStructureElementData($elementName, []);
            $data['attributes'] = $this->mergeBlockAttributes($data, $currentElement);
            $this->updateScheduledData($currentElement, $data);
            $this->evaluateArguments($currentElement, $data);
            $scheduledStructure->setStructureElementData($elementName, $data);
+            $scheduledStructre->unsetElementFromListToRemove($elementName)
        }

Since there seems to be a fix waiting to merge, I'm not going to raise a PR.

KrystynaKabannyk · 2017-03-06T17:21:41Z

hi @thomasnordkvist, the issue has been fixed under MAGETWO-54935 in develop branch, you can find it here and apply for your version: 9bd170d

PieterCappelle · 2017-06-04T06:24:27Z

Please merge this in some upcoming release. Thanks.

korostii · 2017-06-06T09:55:40Z

Hi @KrystynaKabannyk, could you please reopen this issue (until the fix appears in a released 2.1.x version)?
Thanks in advance.

KrystynaKabannyk · 2017-06-06T11:05:06Z

hi @korostii, this issue hasn't been scheduled to be backported, it will go to 2.2.0 release.

korostii · 2017-06-06T12:06:38Z

@KrystynaKabannyk
I hate to underline the obvious, but if the bug was discovered on 2.1.x and then reportedly "fixed", it is commonly expected to see that fix in the closest patch (2.1.x) release.

Considering that for many of the merchants the switch to 2.2 will probably be somewhat painful, resource-heavy (see this marvelous list of backwards-incompatible changes for a taste) and delayed for at least a couple more months, it would make sense to have it on the 2.1.x branch as well. Furthermore, someone from the community just might want this fix badly enough and make pull request aiming 2.1-develop.

Either that, or some disclaimer saying that "this is a known issue that won't ever be fixed in 2.1. Please move along to 2.2". You do know that there are people re-testing every bug they have encountered earlier after each new release in order to see if it got fixed? right?

Anyhow, having the issue marked as "closed" (while there isn't any straightforward way to use it available to ordinary users) is very misleading. Could you at least leave the issue open until 2.2.0 gets released?

KrystynaKabannyk · 2017-06-07T15:13:55Z

hi @korostii, we reviewed the issue again and made the decision to backport it into 2.1.x. Internal ticket for it is created MAGETWO-69715. Thank you for raising this issue again!

PieterCappelle · 2017-06-07T15:16:29Z

Thank god for people like @korostii. Thanks for the effort @KrystynaKabannyk.

magento-engcom-team · 2017-09-12T19:58:18Z

The issue already fixed and will be available in release 2.2.0 very soon

korostii · 2017-09-13T10:47:11Z

Hi @magento-engcom-team,
I am having a bad case of deja vu and I just hope that this message above was an automated one and someone has just missed the discussion above (as opposed to outright ignoring it and turning this thing over again).

The issue is reported and reproduced on 2.1.x
The issue isn't fixed on 2.1.x
How come it's "closed" already (again) ?!

Just trying to make sense of it, please help me understand the issue flow here.
I mean, this isn't your internal JIRA where the only thing that matters is whether is fix is implemented already. People here care whether they can update to the latest release in order to have the bug gone (and they can't, in this case)

Morgon · 2017-11-10T20:24:33Z

@magento-engcom-team @KrystynaKabannyk - Magento committed to backporting this into 2.1 and has marked the ticket as Done (even after @korostii mentioned that Magento may be misunderstanding). However, it's not even in 2.1.10-dev. Please fix the status of this report and update the community on an ETA.

quisse · 2018-03-20T11:27:43Z

Still not backported to 2.1.*?

…in layouts doesn't work -- integration test

magento-engcom-team · 2018-03-26T21:30:10Z

Hi @thomasnordkvist. Thank you for your report.
The issue has been fixed in #14198 by @quisse in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.14 release.

quisse · 2018-03-27T06:16:54Z

@magento-engcom-team Do you mean 2.1.13 or is that one going to be skipped?

okorshenko added the PS label Sep 24, 2015

maksek added the forum label Sep 30, 2015

daim2k5 closed this as completed Nov 10, 2015

daim2k5 reopened this Apr 15, 2016

daim2k5 removed the forum label Apr 15, 2016

vzabaznov assigned rgoncharuk Jun 22, 2016

tkacheva assigned eug123 Jul 1, 2016

tkacheva added Theme bug report labels Jul 8, 2016

vkorotun added Area: Frontend and removed PS labels Aug 3, 2016

rgoncharuk added bug report and removed bug report labels Aug 31, 2016

tkacheva added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 6, 2016

mmansoor-magento pushed a commit that referenced this issue Oct 19, 2016

MAGETWO-54935: [Github #1931] Cancellation of element removal in layo…

d99ed05

…uts doesn't work -- integration test

KrystynaKabannyk closed this as completed Mar 7, 2017

KrystynaKabannyk reopened this Jun 7, 2017

korostii mentioned this issue Jun 19, 2017

setup:static-content:deploy does not create all the required static assets #2976

Closed

magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Area: Frontend Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017

magento-engcom-team closed this as completed Sep 12, 2017

magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Sep 12, 2017

quisse mentioned this issue Mar 20, 2018

[Backport] Can't cancel removal of a block or container in layout by setting remove attribute value to false #14198

Merged

4 tasks

quisse pushed a commit to quisse/magento2 that referenced this issue Mar 23, 2018

MAGETWO-54935: [Github magento#1931] Cancellation of element removal …

2423fac

…in layouts doesn't work -- integration test

magento-engcom-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Mar 26, 2018

quisse self-assigned this Mar 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can't cancel removal of a block or container in layout by setting remove attribute value to false #1931

Can't cancel removal of a block or container in layout by setting remove attribute value to false #1931

thomasnordkvist commented Sep 23, 2015

daim2k5 commented Nov 10, 2015

philippsander commented Mar 16, 2016

thomasnordkvist commented Mar 16, 2016

AntonEvers commented May 26, 2016

BenSpace48 commented Jun 1, 2016 •

edited

Loading

dexterchua19 commented Jun 9, 2016

pboisvert commented Jun 30, 2016

tkacheva commented Jul 1, 2016

philippsander commented Jul 7, 2016

tkacheva commented Jul 8, 2016

Styopchik commented Jul 22, 2016

torreytsui commented Nov 24, 2016 •

edited

Loading

KrystynaKabannyk commented Mar 6, 2017

PieterCappelle commented Jun 4, 2017

korostii commented Jun 6, 2017

KrystynaKabannyk commented Jun 6, 2017

korostii commented Jun 6, 2017

KrystynaKabannyk commented Jun 7, 2017

PieterCappelle commented Jun 7, 2017

magento-engcom-team commented Sep 12, 2017

korostii commented Sep 13, 2017 •

edited

Loading

Morgon commented Nov 10, 2017

quisse commented Mar 20, 2018

magento-engcom-team commented Mar 26, 2018

quisse commented Mar 27, 2018

Can't cancel removal of a block or container in layout by setting remove attribute value to false #1931

Can't cancel removal of a block or container in layout by setting remove attribute value to false #1931

Comments

thomasnordkvist commented Sep 23, 2015

daim2k5 commented Nov 10, 2015

philippsander commented Mar 16, 2016

thomasnordkvist commented Mar 16, 2016

AntonEvers commented May 26, 2016

BenSpace48 commented Jun 1, 2016 • edited Loading

dexterchua19 commented Jun 9, 2016

pboisvert commented Jun 30, 2016

tkacheva commented Jul 1, 2016

philippsander commented Jul 7, 2016

tkacheva commented Jul 8, 2016

Styopchik commented Jul 22, 2016

torreytsui commented Nov 24, 2016 • edited Loading

A limited workaround for the time being

remove="false" seems not implemented

KrystynaKabannyk commented Mar 6, 2017

PieterCappelle commented Jun 4, 2017

korostii commented Jun 6, 2017

KrystynaKabannyk commented Jun 6, 2017

korostii commented Jun 6, 2017

KrystynaKabannyk commented Jun 7, 2017

PieterCappelle commented Jun 7, 2017

magento-engcom-team commented Sep 12, 2017

korostii commented Sep 13, 2017 • edited Loading

Morgon commented Nov 10, 2017

quisse commented Mar 20, 2018

magento-engcom-team commented Mar 26, 2018

quisse commented Mar 27, 2018

BenSpace48 commented Jun 1, 2016 •

edited

Loading

torreytsui commented Nov 24, 2016 •

edited

Loading

`remove="false"` seems not implemented

korostii commented Sep 13, 2017 •

edited

Loading