MAGETWO-52000: [Github][PR]impossible to see what is wrong with cron - unhelpful error message #3189

- Using OM to create TImeZoneProvider.

Author: mazhalai

Diff for: setup/src/Magento/Setup/Model/PackagesData.php

@@ -40,11 +40,6 @@ class PackagesData
      */
     private $packagesAuth;
 
-    /**
-     * @var \Magento\Setup\Model\DateTime\TimeZoneProvider
-     */
-    private $timeZoneProvider;
-
     /**
      * @var  \Magento\Setup\Model\ObjectManagerProvider
      */
@@ -54,21 +49,18 @@ class PackagesData
      * PackagesData constructor.
      *
      * @param \Magento\Framework\Composer\ComposerInformation $composerInformation,
-     * @param \Magento\Setup\Model\DateTime\TimeZoneProvider $timeZoneProvider,
      * @param \Magento\Setup\Model\PackagesAuth $packagesAuth,
      * @param \Magento\Framework\Filesystem $filesystem,
      * @param \Magento\Setup\Model\ObjectManagerProvider $objectManagerProvider
      */
     public function __construct(
         \Magento\Framework\Composer\ComposerInformation $composerInformation,
-        \Magento\Setup\Model\DateTime\TimeZoneProvider $timeZoneProvider,
         \Magento\Setup\Model\PackagesAuth $packagesAuth,
         \Magento\Framework\Filesystem $filesystem,
         \Magento\Setup\Model\ObjectManagerProvider $objectManagerProvider
     ) {
         $this->objectManagerProvider = $objectManagerProvider;
         $this->composerInformation = $composerInformation;
-        $this->timeZoneProvider = $timeZoneProvider;
         $this->packagesAuth = $packagesAuth;
         $this->filesystem = $filesystem;
     }
@@ -133,7 +125,9 @@ private function formatLastSyncData($packagesForInstall, $lastSyncData)
      */
     private function formatSyncDate($syncDate)
     {
-        $timezone = $this->timeZoneProvider->get();
+        $objectManager = $this->objectManagerProvider->get();
+        $timeZoneProvider = $objectManager->get('Magento\Setup\Model\DateTime\TimeZoneProvider');
+        $timezone = $timeZoneProvider->get();
         return [
             'date' => $timezone->formatDateTime(
                 new \DateTime('@'.$syncDate),

Diff for: setup/src/Magento/Setup/Test/Unit/Model/PackagesDataTest.php

@@ -51,8 +51,10 @@ public function setUp()
         $applicationFactory->expects($this->any())->method('create')->willReturn($application);
         $objectManager->expects($this->any())
             ->method('get')
-            ->with('Magento\Framework\Composer\MagentoComposerApplicationFactory')
-            ->willReturn($applicationFactory);
+            ->will($this->returnValueMap([
+                ['Magento\Framework\Composer\MagentoComposerApplicationFactory', $applicationFactory],
+                ['Magento\Setup\Model\DateTime\TimeZoneProvider', $timeZoneProvider]
+            ]));
         $objectManagerProvider->expects($this->any())->method('get')->willReturn($objectManager);
 
         $directoryWrite = $this->getMockForAbstractClass('\Magento\Framework\Filesystem\Directory\WriteInterface');
@@ -86,7 +88,6 @@ public function setUp()
 
         $this->packagesData = new PackagesData(
             $composerInformation,
-            $timeZoneProvider,
             $packagesAuth,
             $filesystem,
             $objectManagerProvider