MAGETWO-52000: [Github][PR]impossible to see what is wrong with cron - unhelpful error message #3189

- fixes for QA issues.

Author: mazhalai

Diff for: setup/src/Magento/Setup/Model/Cron/JobSetCache.php

@@ -54,7 +54,8 @@ public function __construct(
     public function execute()
     {
         try {
-            $this->command->run(new ArrayInput(['command' => $this->command->getName()]), $this->output);
+            $this->params['command'] = $this->command->getName();
+            $this->command->run(new ArrayInput($this->params), $this->output);
         } catch (\Exception $e) {
             $this->status->toggleUpdateError(true);
             throw new \RuntimeException(sprintf('Could not complete %s successfully: %s', $this, $e->getMessage()));

Diff for: setup/src/Magento/Setup/Model/UpdaterTaskCreator.php

@@ -138,12 +138,6 @@ public function createUpdaterTasks(array $postPayload)
                 \Magento\Setup\Model\Cron\JobFactory::JOB_UPGRADE,
                 []
             );
-        } elseif ($jobType == 'disable') {
-            $errorMessage .= $this->updater->createUpdaterTask(
-                [],
-                \Magento\Setup\Model\Updater::TASK_TYPE_MAINTENANCE_MODE,
-                ['enable' => false]
-            );
         }
 
         $enabledCaches = [];
@@ -161,6 +155,14 @@ public function createUpdaterTasks(array $postPayload)
             );
         }
 
+        if ($jobType == 'disable') {
+            $errorMessage .= $this->updater->createUpdaterTask(
+                [],
+                \Magento\Setup\Model\Updater::TASK_TYPE_MAINTENANCE_MODE,
+                ['enable' => false]
+            );
+        }
+
         return $errorMessage;
     }