Rename recurcive method to have more clear understanding

magento · Nov 8, 2018 · e2c9ac0 · e2c9ac0
1 parent b777343
commit e2c9ac0
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/...gento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ExtractDataFromCategoryTree.php b/...gento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ExtractDataFromCategoryTree.php
@@ -53,7 +53,7 @@ public function execute(\Iterator $iterator): array
             $pathElements = explode("/", $category->getPath());
             $this->iteratingCategory = $category;
 
-            $currentLevelTree = $this->generateLevelTree($pathElements, self::START_CATEGORY_FETCH_LEVEL);
+            $currentLevelTree = $this->explodePathToArray($pathElements, self::START_CATEGORY_FETCH_LEVEL);
             if (empty($tree)) {
                 $tree = $currentLevelTree;
             }
@@ -64,7 +64,7 @@ public function execute(\Iterator $iterator): array
     }
 
     /**
-     * Merge together complex categories tree
+     * Merge together complex categories trees
      *
      * @param array $tree1
      * @param array $tree2
@@ -86,23 +86,23 @@ private function mergeCategoriesTrees(array &$tree1, array &$tree2): array
     /**
      * Recursive method to generate tree for one category path
      *
-     * @param $elements
+     * @param $pathElements
      * @param $index
      * @return array
      */
-    private function generateLevelTree($elements, $index): array
+    private function explodePathToArray($pathElements, $index): array
     {
 
         $tree = [];
-        $tree[$elements[$index]]['id'] = $elements[$index];
-        if ($index === count($elements) - 1) {
-            $tree[$elements[$index]] = $this->categoryHydrator->hydrateCategory($this->iteratingCategory);
-            $tree[$elements[$index]]['model'] = $this->iteratingCategory;
+        $tree[$pathElements[$index]]['id'] = $pathElements[$index];
+        if ($index === count($pathElements) - 1) {
+            $tree[$pathElements[$index]] = $this->categoryHydrator->hydrateCategory($this->iteratingCategory);
+            $tree[$pathElements[$index]]['model'] = $this->iteratingCategory;
         }
         $currentIndex = $index;
         $index++;
-        if (isset($elements[$index])) {
-            $tree[$elements[$currentIndex]]['children'] = $this->generateLevelTree($elements, $index);
+        if (isset($pathElements[$index])) {
+            $tree[$pathElements[$currentIndex]]['children'] = $this->explodePathToArray($pathElements, $index);
         }
         return $tree;
     }