Skip to content

Commit

Permalink
MQE-683: [Deprecation] Only use more nested assertion syntax
Browse files Browse the repository at this point in the history
- Indent fixes
  • Loading branch information
KevinBKozan committed Mar 12, 2020
1 parent e7e2b44 commit 58b25ca
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 33 deletions.
58 changes: 29 additions & 29 deletions app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCategoryTest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -70,35 +70,35 @@
<seeOptionIsSelected selector="{{CategoryDesignSection.LayoutDropdown}}" userInput="2 columns with right bar" stepKey="see2ColumnsSelected" />
</test>
<test name="AdminCategoryFormDisplaySettingsUIValidationTest">
<annotations>
<features value="Catalog"/>
<stories value="Default layout configuration MAGETWO-88793"/>
<title value="Category should not be saved once layered navigation price step field is left empty"/>
<description value="Once the Config setting is unchecked Category should not be saved with layered navigation price field left empty"/>
<severity value="AVERAGE"/>
<testCaseId value="MAGETWO-95797"/>
<group value="category"/>
</annotations>
<before>
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
</before>
<after>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
</after>
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="navigateToCategoryPage"/>
<waitForPageLoad time="30" stepKey="waitForPageLoad1"/>
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategory"/>
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{SimpleSubCategory.name}}" stepKey="enterCategoryName"/>
<click selector="{{CategoryDisplaySettingsSection.DisplaySettingTab}}" stepKey="clickOnDisplaySettingsTab"/>
<waitForElementVisible selector="{{CategoryDisplaySettingsSection.filterPriceRangeUseConfig}}" stepKey="wait"/>
<scrollTo selector="{{CategoryDisplaySettingsSection.layeredNavigationPriceInput}}" stepKey="scrollToLayeredNavigationField"/>
<uncheckOption selector="{{CategoryDisplaySettingsSection.filterPriceRangeUseConfig}}" stepKey="uncheckConfigSetting"/>
<click selector="{{AdminCategoryMainActionsSection.SaveButton}}" stepKey="saveCategory"/>
<see selector="{{AdminCategoryBasicFieldSection.FieldError('uid')}}" userInput="This is a required field." stepKey="seeErrorMessage"/>
<!-- Verify that the Layered navigation price step field has the required indicator -->
<comment userInput="Check if Layered navigation price field has required indicator icon" stepKey="comment" />
<executeJS function="{{CategoryDisplaySettingsSection.RequiredFieldIndicator('filter_price_range')}}" stepKey="getRequiredFieldIndicator"/>
<assertEquals message="pass" stepKey="assertRequiredFieldIndicator1">
<annotations>
<features value="Catalog"/>
<stories value="Default layout configuration MAGETWO-88793"/>
<title value="Category should not be saved once layered navigation price step field is left empty"/>
<description value="Once the Config setting is unchecked Category should not be saved with layered navigation price field left empty"/>
<severity value="AVERAGE"/>
<testCaseId value="MAGETWO-95797"/>
<group value="category"/>
</annotations>
<before>
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
</before>
<after>
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
</after>
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="navigateToCategoryPage"/>
<waitForPageLoad time="30" stepKey="waitForPageLoad1"/>
<click selector="{{AdminCategorySidebarActionSection.AddSubcategoryButton}}" stepKey="clickOnAddSubCategory"/>
<fillField selector="{{AdminCategoryBasicFieldSection.CategoryNameInput}}" userInput="{{SimpleSubCategory.name}}" stepKey="enterCategoryName"/>
<click selector="{{CategoryDisplaySettingsSection.DisplaySettingTab}}" stepKey="clickOnDisplaySettingsTab"/>
<waitForElementVisible selector="{{CategoryDisplaySettingsSection.filterPriceRangeUseConfig}}" stepKey="wait"/>
<scrollTo selector="{{CategoryDisplaySettingsSection.layeredNavigationPriceInput}}" stepKey="scrollToLayeredNavigationField"/>
<uncheckOption selector="{{CategoryDisplaySettingsSection.filterPriceRangeUseConfig}}" stepKey="uncheckConfigSetting"/>
<click selector="{{AdminCategoryMainActionsSection.SaveButton}}" stepKey="saveCategory"/>
<see selector="{{AdminCategoryBasicFieldSection.FieldError('uid')}}" userInput="This is a required field." stepKey="seeErrorMessage"/>
<!-- Verify that the Layered navigation price step field has the required indicator -->
<comment userInput="Check if Layered navigation price field has required indicator icon" stepKey="comment" />
<executeJS function="{{CategoryDisplaySettingsSection.RequiredFieldIndicator('filter_price_range')}}" stepKey="getRequiredFieldIndicator"/>
<assertEquals message="pass" stepKey="assertRequiredFieldIndicator1">
<actualResult type="variable">getRequiredFieldIndicator</actualResult>
<expectedResult type="string">"*"</expectedResult>
</assertEquals>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@
</actionGroup>
<grabTextFrom selector="{{AdminConfigurableProductFormSection.currentAttribute}}" stepKey="grabAttribute"/>
<assertNotEmpty stepKey="assertNotEmpty">
<actualResult type="const">$grabAttribute</actualResult>
</assertNotEmpty>
<actualResult type="const">$grabAttribute</actualResult>
</assertNotEmpty>

<!-- Create bundle Product -->
<createData entity="SimpleSubCategory" stepKey="createSubCategory"/>
Expand Down Expand Up @@ -152,8 +152,8 @@
</actionGroup>
<grabTextFrom selector="{{AdminProductFormBundleSection.currentBundleOption}}" stepKey="grabBundleOption"/>
<assertNotEmpty stepKey="assertBundleOptionNotEmpty">
<actualResult type="const">$grabBundleOption</actualResult>
</assertNotEmpty>
<actualResult type="const">$grabBundleOption</actualResult>
</assertNotEmpty>

<!-- Create sales rule -->
<createData entity="ActiveSalesRuleCoupon50" stepKey="createCartPriceRule"/>
Expand Down

0 comments on commit 58b25ca

Please sign in to comment.