fix bug on newsletter subscription action when user use an existing e…

…mail already subscribed
magento · Apr 1, 2016 · 3f490b4 · 3f490b4
1 parent 2abc5a3
commit 3f490b4
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/app/code/Magento/Newsletter/Controller/Subscriber/NewAction.php b/app/code/Magento/Newsletter/Controller/Subscriber/NewAction.php
@@ -121,6 +121,15 @@ public function execute()
                 $this->validateGuestSubscription();
                 $this->validateEmailAvailable($email);
 
+                $subscriber = $this->_subscriberFactory->create()->loadByEmail($email);
+                if ($subscriber->getId()
+                    && $subscriber->getSubscriberStatus() == \Magento\Newsletter\Model\Subscriber::STATUS_SUBSCRIBED
+                ) {
+                    throw new \Magento\Framework\Exception\LocalizedException(
+                        __('This email address is already subscribed.')
+                    );
+                }
+
                 $status = $this->_subscriberFactory->create()->subscribe($email);
                 if ($status == \Magento\Newsletter\Model\Subscriber::STATUS_NOT_ACTIVE) {
                     $this->messageManager->addSuccess(__('The confirmation request has been sent.'));