JS-356: code refactoring

magento · Dec 10, 2015 · 296d777 · 296d777
1 parent f213258
commit 296d777
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/lib/web/mage/gallery/gallery.less b/lib/web/mage/gallery/gallery.less
@@ -891,6 +891,10 @@
                 transition-property: none;
             }
         }
+        iframe {
+            width: calc(~'100% - @{fotorama-arw-size} * 2');
+            left: @fotorama-arw-size;
+        }
     }
 }
 

diff --git a/lib/web/magnifier/magnify.js b/lib/web/magnifier/magnify.js
@@ -731,17 +731,15 @@ define([
          * Displays navigation arrows on preview if it contains ifraime.
          * @param fotorama - object of fotorama
          */
-        var showArrows = function (fotorama) {
-            if (fotorama.activeFrame.$stageFrame.find(':has(iframe)').length || 
-                ($(gallerySelector).data('fotorama').fullScreen && config.fullscreen.arrows) || 
-                (!($(gallerySelector).data('fotorama').fullScreen && config.arrows))) {
-                fotorama.setOptions({
-                    arrows: true
-                });
+        function showArrows (fotorama) {
+            var $arrows = $('[data-gallery-role="arrow"]');
+
+            if ((fotorama.activeFrame.$stageFrame.find(':has(iframe)').length && fotorama.fullScreen) || 
+                (fotorama.fullScreen && config.fullscreen.arrows) || 
+                (!fotorama.fullScreen && config.arrows)) {
+                $arrows.show();
             } else {
-                fotorama.setOptions({
-                    arrows: false
-                });
+                $arrows.hide();
             }
         };