Fix queue subscribers adding performance

magento · Apr 11, 2016 · 01d907a · 01d907a
1 parent 4e1a1bc
commit 01d907a
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/app/code/Magento/Newsletter/Model/ResourceModel/Queue.php b/app/code/Magento/Newsletter/Model/ResourceModel/Queue.php
@@ -80,13 +80,13 @@ public function addSubscribersToQueue(ModelQueue $queue, array $subscriberIds)
             $subscriberIds
         );
 
-        $usedIds = $connection->fetchCol($select);
+        $usedIds = array_flip($connection->fetchCol($select));
+        $subscriberIds = array_flip($subscriberIds);
+        $newIds = array_diff_key($subscriberIds, $usedIds);
+
         $connection->beginTransaction();
         try {
-            foreach ($subscriberIds as $subscriberId) {
-                if (in_array($subscriberId, $usedIds)) {
-                    continue;
-                }
+            foreach ($newIds as $subscriberId) {
                 $data = [];
                 $data['queue_id'] = $queue->getId();
                 $data['subscriber_id'] = $subscriberId;