fix: workaround for "thread context was already set" exception #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrkwiecinski
force-pushed
the
hotfix-thread-exists
branch
from
5425f82
to
920d983
Compare
VitaliyBoyko
approved these changes
Jul 13, 2024
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "thread context was already set" exception triggered on every popup display.
The proper fix is going to be more involved and is tracked in #2080.
I'll pick it up at some point in the future. It's going to require reworking a JDialog implementation to DialogWrapper. It will be more time consuming from implementation and testing point of view.
Contribution checklist (*)