Skip to content

magento/magento2-page-builder#504: Mismatching Strict Type#528

Closed
bluemwhitew wants to merge 2 commits into
developfrom
504_mismatching-strict-type
Closed

magento/magento2-page-builder#504: Mismatching Strict Type#528
bluemwhitew wants to merge 2 commits into
developfrom
504_mismatching-strict-type

Conversation

@bluemwhitew
Copy link
Copy Markdown
Contributor

Description (*)

Fixed an inconsistency where strict types that were not present in the original method were being applied.

Fixed Issues

  1. https://www.github.com/magento/magento2-page-builder/issues/504

Builds

N/A

Related Pull Requests

N/A

Manual Testing Scenarios (*)

N/A

Questions or Comments

N/A

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

- Extending Integration Test
- Adding Null Coalescing Operator
- Removing Strict Type from `$result` Parameter (Cheers, @dannynimmo)
@bluemwhitew
Copy link
Copy Markdown
Contributor Author

@magento run all tests

@ghost ghost added 2.4-develop: 5️⃣ 2.4-develop: :five: 2.4-develop: 4️⃣ 2.4-develop: :four: 2.4-develop: 3️⃣ 2.4-develop: :three: 2.4-develop: 2️⃣ 2.4-develop: :two: and removed 2.4-develop: 5️⃣ 2.4-develop: :five: 2.4-develop: 4️⃣ 2.4-develop: :four: 2.4-develop: 3️⃣ 2.4-develop: :three: labels Jun 11, 2020
@omiroshnichenko omiroshnichenko added the 2.4-develop: exclude 2.4-develop: exclude label Jun 11, 2020
@ghost ghost removed the 2.4-develop: 2️⃣ 2.4-develop: :two: label Jun 11, 2020
@bluemwhitew
Copy link
Copy Markdown
Contributor Author

Closing PR. See #504 for further information.

@omiroshnichenko omiroshnichenko deleted the 504_mismatching-strict-type branch July 20, 2020 17:57
magento-devops-reposync-svc pushed a commit that referenced this pull request May 13, 2026
AC-16922: Category image upload button not clickable on default store…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Magento\PageBuilder\Plugin\Filter\TemplatePlugin" mismatching strict type

2 participants