MSI-325: implemented fulltext search for Manage Stocks grid#336
Closed
stansm wants to merge 2 commits into
Closed
Conversation
stansm
force-pushed
the
MSI-325_partial_search_by_name_in_manage_stock
branch
from
3685230 to
d773c04
Compare
rogyar
suggested changes
Mar 29, 2018
| { | ||
| $indexes = $collection->getConnection()->getIndexList($indexTable); | ||
| foreach ($indexes as $index) { | ||
| if (strtoupper($index['INDEX_TYPE']) === 'FULLTEXT') { |
Contributor
There was a problem hiding this comment.
Just a minor thing, I believe that using \Magento\Framework\DB\Adapter\AdapterInterface::INDEX_TYPE_FULLTEXT for comparison instead of the hardcoded value is a good idea.
stansm
force-pushed
the
MSI-325_partial_search_by_name_in_manage_stock
branch
from
1cf0e05 to
79d1cd5
Compare
stansm
force-pushed
the
MSI-325_partial_search_by_name_in_manage_stock
branch
from
79d1cd5 to
31732d7
Compare
Contributor
Author
|
@rogyar I've fixed this + resolved conflicts and moved fulltext index declaration into db_schema.xml |
|
Closed due to #1285 |
ishakhsuvarov
deleted the
MSI-325_partial_search_by_name_in_manage_stock
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented full text search for Manage Stocks grid
Description
Please review the approach used in this PR and if it's OK I'll also commit changes for #326 in this branch.
Fixed Issues (if relevant)
Manual testing scenarios
See linked issue(s)
Contribution checklist