This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
Prevent undefined index warning before setting shipping method #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
list
could cause and undefined index error when address rates had beencollected and the shipping method was not set. This commit checks that the
shipping method is set prior to resolving.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Reliably reproducing the original error depends on the order of the field properties in the query,
available_shipping_methods
MUST precedeselected_shipping_method
.Contribution checklist (*)