Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 7, 2018

Description

Use SVG Crowdin badge instead of PNG, for visual consistency with others.

Also add some missing fullstops, and because there's just one option under "Install Magento", there's no need to say "see either".

Manual testing scenarios

  1. Visit the README in the PR
  2. Check the badge and text is improved

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [n/a] All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Before

image

After

image

And fix some text
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 7, 2018

CLA assistant check
All committers have signed the CLA.

@naydav
Copy link
Contributor

naydav commented Oct 9, 2018

Hi @hugovk,
This repository is related to the GraphQL project
Could you close this PR and create a new one (from the same branch) to https://github.com/magento/magento2/pulls
Thanks

@hugovk
Copy link
Contributor Author

hugovk commented Oct 9, 2018

@naydav Hi, I've already made a similar PR to https://github.com/magento/magento2/, please see magento/magento2#18439.

Is it so that when that is merged, the README in this repo will also get updated? Thanks.

@naydav
Copy link
Contributor

naydav commented Oct 9, 2018

@hugovk,
Yes, after merging magento/magento2#18439 this repo will be automatically updated
Thanks for the contribution!

@naydav naydav closed this Oct 9, 2018
@hugovk hugovk deleted the patch-1 branch October 9, 2018 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants