Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Add discount information to Cart #683

Closed
naydav opened this issue May 7, 2019 · 1 comment
Closed

Add discount information to Cart #683

naydav opened this issue May 7, 2019 · 1 comment
Labels
Contribution Day Tickets is good for start on Contribution Day

Comments

@naydav
Copy link
Contributor

naydav commented May 7, 2019

Need to add information about discounts to Cart type and Cart Item type

For easy clarification of requested data need to create cart rule in admin and pick up information from the shopping cart page on frontend

Needed data:

  • shopping cart catalog promotion (price on sale) display
  • shopping cart line item promotion display (BOGO $/%)

Scheme
app/code/Magento/QuoteGraphQl/etc/schema.graphqls

type CartPrices

Functionality should be covered with API-functional tests
Examples:
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

Guide:
https://devdocs.magento.com/guides/v2.3/graphql/functional-testing.html

@naydav naydav added the Contribution Day Tickets is good for start on Contribution Day label May 7, 2019
@naydav naydav added this to the Release: 2.3.3 milestone May 7, 2019
@naydav naydav changed the title Add discount information to Cart Add possibility to get discount information at Cart query May 8, 2019
@naydav naydav changed the title Add possibility to get discount information at Cart query Add discount information to Cart query May 8, 2019
@naydav naydav changed the title Add discount information to Cart query Add discount information to Cart May 8, 2019
@rogyar rogyar self-assigned this May 11, 2019
lenaorobei added a commit that referenced this issue Jun 11, 2019
lenaorobei added a commit that referenced this issue Jun 12, 2019
- extracted discount cases to separate test class;
- added case for no discount applied;
- return `null` for discount node if amount is 0.
@naydav
Copy link
Contributor Author

naydav commented Jun 19, 2019

#717

@naydav naydav closed this as completed Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Day Tickets is good for start on Contribution Day
Projects
None yet
Development

No branches or pull requests

2 participants