Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Update attribute descriptions for 2.3.4 #5660

Merged
merged 10 commits into from
Oct 11, 2019
Merged

GraphQL: Update attribute descriptions for 2.3.4 #5660

merged 10 commits into from
Oct 11, 2019

Conversation

keharper
Copy link
Contributor

@keharper keharper commented Oct 11, 2019 •
edited
Loading

@keharper keharper added Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc Community Docs impacted by community code contribution 2.3.4 Magento 2.3.4 changes labels Oct 11, 2019
@keharper keharper self-assigned this Oct 11, 2019
@keharper keharper requested a review from erikmarr October 11, 2019 15:36
erikmarr
erikmarr reviewed Oct 11, 2019
View reviewed changes
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of clarifying edits.

@keharper
Copy link
Contributor Author

@erikmarr Updated the PR to address your comments

@keharper
Copy link
Contributor Author

running tests

@keharper keharper merged commit 4605d2e into develop Oct 11, 2019
@ghost
Copy link

ghost commented Oct 11, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the kh_graphql-comm-prs-234 branch October 11, 2019 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikmarr erikmarr erikmarr approved these changes

Assignees

@keharper keharper

@erikmarr erikmarr

Labels
2.3.4 Magento 2.3.4 changes Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keharper @erikmarr