Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Fix typo in regular expression string #1450

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Conversation

jahvi
Copy link
Contributor

@jahvi jahvi commented Oct 11, 2017

It should say "regular expressions" instead of "regular exceptions".

It should say "regular expressions" instead of "regular exceptions".
@keharper
Copy link
Contributor

Chuckling at this typo. Thanks for fixing it.

@keharper keharper merged commit 0750703 into magento:develop Oct 12, 2017
@hostep
Copy link
Contributor

hostep commented Oct 14, 2017

@jahvi, @keharper: this fix is incorrect.

The line which needs to be changed is:
In the Search String box specify the user-agent using either normal strings or regular exceptions (PCRE).

The line which is now changed was originally correct.

@jahvi: can you create a new PR which fixes this? Thanks!

@jahvi
Copy link
Contributor Author

jahvi commented Oct 14, 2017

@hostep My bad, I'll create a new PR with the correct fix.

@jahvi jahvi deleted the patch-1 branch October 14, 2017 14:59
magento-cicd2 pushed a commit that referenced this pull request Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants