This repository was archived by the owner on Apr 29, 2019. It is now read-only.
Removed method annotation without argument from PHPDoc#152
Merged
magento-engcom-team merged 2 commits intomagento-engcom:2.3-developfrom Nov 22, 2018
Conversation
Contributor
Contributor
|
@VoronoyAlexandr thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
|
Hi @VoronoyAlexandr thanks for this pull request. Could you check the static tests. Thanks |
Contributor
Author
|
Good day @dmanners . Done with this errors. |
dmanners
approved these changes
Nov 16, 2018
Contributor
dmanners
left a comment
There was a problem hiding this comment.
Looks good, let me process this PR for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added argument to PHPDoc annotation @method setRowClickCallback(string $value)
Fixed Issues
#125 Clean Up Magento/ImportExport/Block/Adminhtml/Export/Filter
Manual testing scenarios (*)
Run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Block/Adminhtml/Export/Filter.php
Contribution checklist (*)