This repository was archived by the owner on Apr 29, 2019. It is now read-only.
Fixed miss called property in getStoreIdByCode method#143
Merged
magento-engcom-team merged 2 commits intomagento-engcom:2.3-developfrom Nov 14, 2018
maxalmonte14:improvement/supress_undefined_storeIdToCode_property_error
Merged
Fixed miss called property in getStoreIdByCode method#143magento-engcom-team merged 2 commits intomagento-engcom:2.3-developfrom maxalmonte14:improvement/supress_undefined_storeIdToCode_property_error
magento-engcom-team merged 2 commits intomagento-engcom:2.3-developfrom
maxalmonte14:improvement/supress_undefined_storeIdToCode_property_error
Conversation
Contributor
|
Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information. |
dmanners
previously approved these changes
Oct 29, 2018
Contributor
|
@maxalmonte14 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
|
Hi @maxalmonte14 I push 1 commit to this branch (b552406) to fix some php code style issues. |
Contributor
Author
|
@dmanners excellent 👌 |
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR solves the problem addressed in #134
Fixed Issues (if relevant)
Manual testing scenarios (*)
./vendor/bin/phpstan analyse app/code/Magento/BundleImportExport/Model/Import/Product/Type/Bundle.phpas described in Clean up Model/Import/Product/Type/Bundle.php #134, after this implementation the following error shouldn't be presentContribution checklist (*)