This repository was archived by the owner on Apr 29, 2019. It is now read-only.
Feature/import success page improvement#138
Merged
magento-engcom-team merged 2 commits intomagento-engcom:2.3-developfrom Nov 8, 2018
staniag:feature/importSuccessPageImprovement
Merged
Feature/import success page improvement#138magento-engcom-team merged 2 commits intomagento-engcom:2.3-developfrom staniag:feature/importSuccessPageImprovement
magento-engcom-team merged 2 commits intomagento-engcom:2.3-developfrom
staniag:feature/importSuccessPageImprovement
Conversation
dmanners
suggested changes
Oct 29, 2018
|
|
||
| $noticeHtml = $this->historyModel->getSummary(); | ||
|
|
||
| if($this->historyModel->getErrorFile()) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if($this->historyModel->getErrorFile()) { | |
| if ($this->historyModel->getErrorFile()) { |
We should have an extra space after the if keyword to match our coding standards.
dmanners
approved these changes
Oct 29, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 8, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)