Skip to content

[minor] Scryfall image adjustments #14166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
muz wants to merge 4 commits into from
Closed

[minor] Scryfall image adjustments #14166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1de4f1c
Replace standard card back with high resolution image from Scryfall
muz Jan 4, 2026
af7850a
Much more threads for concurrent image downloads. This is really not …
muz Jan 4, 2026
0c03e65
Fix [bot] Blitzwing, Cruel Tormenter flip side name and clean up imports
muz Jan 4, 2026
cfdb291
Update average size of images from Scryfall based on complete dumps
muz Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Mage.Client/src/main/java/org/mage/plugins/card/dl/sources/DirectLinksForDownload.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class DirectLinksForDownload implements Iterable<DownloadJob> {
public static final String cardbackFilename = "cardback.jpg";

static {
directLinks.put(cardbackFilename, "https://upload.wikimedia.org/wikipedia/en/a/aa/Magic_the_gathering-card_back.jpg");
directLinks.put(cardbackFilename, "https://backs.scryfall.io/large/0/a/0aeebaf5-8c7d-4636-9e82-8c27447861f7.jpg");
Copy link
Member

@JayDi85 JayDi85 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong, do not use any guid or io links -- it's cdn related and can be changed any time by scryfall. Only api links must be used.

}

private final File outDir;
Expand Down
4 changes: 2 additions & 2 deletions Mage.Client/src/main/java/org/mage/plugins/card/dl/sources/ScryfallImageSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,8 +757,8 @@ public String getSourceName() {

@Override
public float getAverageSizeKb() {
// June 2024: MH3 set - 46450 Kb / 332 = 140 Kb
return 140f;
// Jan 2026: 90354 images, average of 201.1 Kb
return 201f;
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions Mage.Client/src/main/java/org/mage/plugins/card/dl/sources/ScryfallImageSourceNormal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ public CardImageUrls generateTokenUrl(CardDownloadData card) throws Exception {

@Override
public float getAverageSizeKb() {
// June 2024: MH3 set - 30500 Kb / 332 = 92 Kb
return 92f;
// Jan 2026: 90354 images, average of 101.1 Kb
return 101f;
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions Mage.Client/src/main/java/org/mage/plugins/card/dl/sources/ScryfallImageSourceSmall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ public CardImageUrls generateTokenUrl(CardDownloadData card) throws Exception {

@Override
public float getAverageSizeKb() {
// June 2024: MH3 set - 4500 Kb / 332 = 14 Kb
return 14f;
// Jan 2026: 90354 images, average of 15.5 Kb
return 16f;
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public DownloadPicturesService() {
reloadLanguagesForSelectedSource();

// DOWNLOAD THREADS
uiDialog.getDownloadThreadsCombo().setModel(new DefaultComboBoxModel<>(new String[]{"10", "9", "8", "7", "6", "5", "4", "3", "2", "1"}));
uiDialog.getDownloadThreadsCombo().setModel(new DefaultComboBoxModel<>(new String[]{"100", "75", "50", "40", "30", "20", "15", "10", "5", "1"}));
Copy link
Member

@JayDi85 JayDi85 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need such big values -- it can be unstable (zip storage mode easy to fail), also it can be banned by scryfall (it allow any rate limits on cdn/io links, but I don't trust it). So 1 - 20 are good.

uiDialog.getDownloadThreadsCombo().setSelectedItem(String.valueOf(DEFAULT_DOWNLOAD_THREADS));

// REDOWNLOAD
Expand Down
12 changes: 8 additions & 4 deletions Mage.Sets/src/mage/cards/b/BlitzwingCruelTormentor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package mage.cards.b;

import java.util.UUID;

import mage.abilities.Ability;
import mage.abilities.common.DealsCombatDamageToAPlayerTriggeredAbility;
import mage.abilities.effects.OneShotEffect;
Expand All @@ -13,16 +15,18 @@
import mage.abilities.triggers.BeginningOfEndStepTriggeredAbility;
import mage.cards.CardSetInfo;
import mage.cards.TransformingDoubleFacedCard;
import mage.constants.*;
import mage.constants.CardType;
import mage.constants.Duration;
import mage.constants.Outcome;
import mage.constants.SubType;
import mage.constants.SuperType;
import mage.game.Game;
import mage.game.permanent.Permanent;
import mage.players.Player;
import mage.target.common.TargetOpponent;
import mage.util.RandomUtil;
import mage.watchers.common.PlayerLostLifeWatcher;

import java.util.UUID;

/**
* @author TheElk801
*/
Expand All @@ -31,7 +35,7 @@ public final class BlitzwingCruelTormentor extends TransformingDoubleFacedCard {
public BlitzwingCruelTormentor(UUID ownerId, CardSetInfo setInfo) {
super(ownerId, setInfo,
new SuperType[]{SuperType.LEGENDARY}, new CardType[]{CardType.ARTIFACT, CardType.CREATURE}, new SubType[]{SubType.ROBOT}, "{5}{B}",
"Blitzwing Adaptive Assailant",
"Blitzwing, Adaptive Assailant",
new SuperType[]{SuperType.LEGENDARY}, new CardType[]{CardType.ARTIFACT}, new SubType[]{SubType.VEHICLE}, "B");


Expand Down
6 changes: 3 additions & 3 deletions Mage/src/main/java/mage/cards/repository/TokenRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,8 @@ private static ArrayList<TokenInfo> loadXmageTokens() {
ArrayList<TokenInfo> res = new ArrayList<>();

// Backface
// TODO: can't find backface's api url so use direct link from third party site instead (must be replaced to scryfall someday)
res.add(createXmageToken(XMAGE_IMAGE_NAME_FACE_DOWN_MANUAL, 1, "https://upload.wikimedia.org/wikipedia/en/a/aa/Magic_the_gathering-card_back.jpg"));
// Can't find backface via the API, so use direct image link
res.add(createXmageToken(XMAGE_IMAGE_NAME_FACE_DOWN_MANUAL, 1, "https://backs.scryfall.io/large/0/a/0aeebaf5-8c7d-4636-9e82-8c27447861f7.jpg"));
Copy link
Member

@JayDi85 JayDi85 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no guid links allow


// Copy
// https://scryfall.com/search?q=include%3Aextras+unique%3Aprints+type%3Atoken+copy&unique=cards&as=grid&order=name
Expand Down Expand Up @@ -332,7 +332,7 @@ private static ArrayList<TokenInfo> loadXmageTokens() {

// Helper emblem (for global card hints)
// use backface for it
res.add(createXmageToken(XMAGE_IMAGE_NAME_HELPER_EMBLEM, 1, "https://upload.wikimedia.org/wikipedia/en/a/aa/Magic_the_gathering-card_back.jpg"));
res.add(createXmageToken(XMAGE_IMAGE_NAME_HELPER_EMBLEM, 1, "https://backs.scryfall.io/large/0/a/0aeebaf5-8c7d-4636-9e82-8c27447861f7.jpg"));
Copy link
Member

@JayDi85 JayDi85 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no guid link allow


return res;
}
Expand Down