-
Notifications
You must be signed in to change notification settings - Fork 857
Fix card gen for Ixalan Commander #14161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not convinced by the reasoning, even if both aspects ought to be fixed. Seems to have been erroneously removed in 5b2629f, and the set was renamed by 7d5b117. Are there any other sets that need to be renamed in known-sets.txt? (also, not directly related to this PR but LCC needs reprints added - both 50 and 82 are printings, but 82 is the base printing) |
|
@xenohedron i agree, i was mistaken. If there should be an entry for each file, there are quite a few missing/not named correctly (this is files that do not appear in unknown sets
|
|
Hmm. @theelk801 could you comment on the usage of known-sets.txt and whether this matters in practice? |
|
As far as I know it's only used for generating card files with |
I was looking to try a card from this set, and noticed it had been implemented, but was unusable.
The reason seems to have been that
known-sets.txtname for the set does not match, so the Util script did not create the set entry.