Fix card gen for Ixalan Commander #14161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Not convinced by the reasoning, even if both aspects ought to be fixed. Seems to have been erroneously removed in 5b2629f, and the set was renamed by 7d5b117. Are there any other sets that need to be renamed in known-sets.txt? (also, not directly related to this PR but LCC needs reprints added - both 50 and 82 are printings, but 82 is the base printing) |
Contributor
Author
|
@xenohedron i agree, i was mistaken. If there should be an entry for each file, there are quite a few missing/not named correctly (this is files that do not appear in unknown sets
|
Contributor
|
Hmm. @theelk801 could you comment on the usage of known-sets.txt and whether this matters in practice? |
Contributor
|
As far as I know it's only used for generating card files with |
xenohedron
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking to try a card from this set, and noticed it had been implemented, but was unusable.
The reason seems to have been that
known-sets.txtname for the set does not match, so the Util script did not create the set entry.