[FIC] Implement Tidus, Yuna's Guardian#13555
Merged
Conversation
Contributor
|
are there existing tests covering any of this? |
Contributor
Author
|
I don't think so, I should probably write some |
Contributor
Author
|
ok it looks like there are tests for this and they're passing so I'm just gonna merge it |
xenohedron
reviewed
May 23, 2025
| this.addAbility(ability); | ||
|
|
||
| // Cheer - Whenever one or more creatures you control with counters on them deal combat damage to a player, you may draw a card and proliferate. Do this only once each turn. | ||
| ability = new OneOrMoreCombatDamagePlayerTriggeredAbility( |
Contributor
Author
There was a problem hiding this comment.
missed the forest for the trees, thanks for the catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
made some changes that seem worth a PR to at least check for a test failure
#13362