Discord bug report: Firkraag doesn't trigger with War's Toll

[Grath]

Added an extra function to RestrictionEffect to allow it to update the creaturesForcedToAttack map at the end of checking restriction effects, used this to make War's Toll mark every creature as having been forced to attack for the purposes of Firkraag.

[JayDi85]

[[Firkraag]] [[War's Toll]]

[github-actions]

Firkraag, Cunning Instigator - (Gatherer) (Scryfall) (EDHREC)

{3}{U}{R}
Legendary Creature — Dragon
3/3
Flying, haste
Whenever one or more Dragons you control attack an opponent, goad target creature that player controls.
Whenever a creature deals combat damage to one of your opponents, if that creature had to attack this combat, you put a +1/+1 counter on Firkraag and you draw a card.

War's Toll - (Gatherer) (Scryfall) (EDHREC)

{3}{R}
Enchantment
Whenever an opponent taps a land for mana, tap all lands that player controls.
If a creature an opponent controls attacks, all creatures that opponent controls attack if able.

[JayDi85]

1. Workaround looks strange. I’ll look at it. Maybe all that checkAfter must be renamed or use another logic (it’s strange to call one time requirement effects and multiple times restriction effects)
2. Need tests.
3. Miss clear of creaturesForcedToAttack on removing from attack? Human player can select and unselect creature from attack. Make sure it’s clear restrictions on removing from attack.

[xenohedron]

I don't like this because War's Toll itself is not implemented correctly in the first place. See #8595.