rework-face-down-cards by Jmlundeen · Pull Request #13486 · magefree/mage

Jmlundeen · 2025-03-30T02:54:42Z

This changes face-down cards to only reveal information to players who have been allowed to see the cards instead of giving the controller access

fixes #3583, fixes #11881, fixes #12610, fixes #11896, fixes #12161, fixes #6967, fixes #8109, fixes #11191, fixes #10800, fixes #11752, fixes #12163, fixes #12880, fixes #12882, fixes #13543

Remove day/night button after morph card flips Update Yedora to set proper attributes

Uses makeFaceDownObject now

reduce cognitive complexity of constructor separating into different functions move some settings into shared function face down cards correctly display information now

add day/night button when a card becomes face down properly assign face/back for multi face cards that already have a day/night button and become face down hide the button when a card is no longer transformable

gives players the ability to see info on face-down cards for the duration of exile puts game engine more in-line with rule 406.3

add new exile logic

filter for creature permanents

give controller ability to look at exiled cards for duration of game

Also remove visibility when removing from exile zone

…one visibility

remove unnecessary custom effects with makeCardPlayable and exile zone visibility

add exile zone visibility

add exile zone visibility remove unnecessary look at effect

update exile effect

update exile effect remove unnecessary look effect

update related cards that use methods

update exile effect remove unnecessary look at effect

update exile effect remove unnecessary look at effect play effect now considers ownership

created test class for both effects using Kheru Mind-Eater and Colfenor's Plans

Mage.Common/src/main/java/mage/view/CardView.java

After processing copy effects 1a layer, layer effects are refreshed. This allows copied morph cards that were turned face down to have the turn face up ability.

Jmlundeen · 2025-04-03T15:57:22Z

I think this is now ready for critique, face down cards more accurately represent game state.

example showing visibility on gaining control with bane alley broker, owner cannot see their card in exile (gonti), and no visibility for either player (pyxis)

example showing Ixidron flipping, ignoring transform permanents and mdfc, copying morph face down gives flip ability, and face down copies don't retain their copied abilities

JayDi85 · 2025-04-05T13:41:23Z

Check issue with lookAt problems — are there related fixes in current PR?
- lookAtCards/reveal and fireUpdatePlayersEvent must be reworked #12480
Check face down info issues — what can be closed in current PR?:
Make sure game logs compatible with face down too (no info discloses, no errors/popups on mouse over, etc)

P.S. Some issues can be outdated due new face down “look at” logic in current PR — that’s ok

JayDi85 · 2025-04-05T13:51:47Z

It’s in draft state — are you planning to add more changes in current PR?

Jmlundeen · 2025-04-05T14:26:33Z

Ooops, yeah should have took it out of draft. I'll take a look at the issues to confirm which can be closed.

Jmlundeen · 2025-04-05T18:29:26Z

lookAtCards/reveal and fireUpdatePlayersEvent must be reworked #12480
Just the face down part of this issue is handled. visibility should carry between exiled zones.
Turning a cloned creature face-down does not remove its abilities #3583 -- fixed
Face down cloaked cards leak info about being a creature #13431 -- needs research, could be added to this PR
Face down cards in exile being shown/revealed improperly #11881 -- fixed
Issues copying face-down spells #12014 -- need more research
Keep better track of set of players that know about a face down permanent's real card. #12159 -- needs more work outside of exile
Face Down turned face up wrongly show they have a back side. #12160 -- fixed
gui: manifested creatures retain double faced icon after being turned face up #11896 -- fixed
Clone of a Face Down permanent is weird #12161 -- fixed
Manifested Creatures with Eerie Interlude. #6967 -- fixed
A forest creature made into a forest by Yedora, Grave Gardener can not be morphed #8109 -- fixed
Modal double-faced cards can be turned face down while on the battlefield #11191 -- fixed
Can't activate morph ability of permanent face-down from another effect #10800 -- fixed
[FRF] Supplant Form on a morph creates a 0/0 #8793
A 2/2 empty creature is created but still issue with a face-down copy. A token of the copied card is created.

This reverts commit c4c1df1.

Cascade now checks the spell instead of the cards mana value

Spell target text, for a spell on the stack, is now hidden if not the controller of target

face down spells on the stack will log the spell with a linked object and appropriate id

face down permanents create a linked object with id

JayDi85 · 2025-04-16T01:15:53Z

@Jmlundeen can you check new issue with Yedora, Grave Gardener #13543 and add it to the list (if it was fixed here)?

Jmlundeen · 2025-04-16T03:07:14Z

Yup, that will be fixed as well

PurpleCrowbar · 2025-04-24T21:56:59Z

How's this looking? This is likely one of the most important PRs in recent memory based on sheer quantity of bugs it fixes for many very broken cards so should probably be merged before the next release.

JayDi85 · 2025-04-24T22:00:02Z

It's need code review. I'll do it later

# Conflicts: # Mage.Common/src/main/java/mage/view/CardView.java

PurpleCrowbar · 2025-06-29T20:56:45Z

Any word on this? Would be good to have all of these issues closed before the next release

# Conflicts: # Mage.Sets/src/mage/cards/e/EtherealValkyrie.java # Mage.Sets/src/mage/cards/g/GontiNightMinister.java # Mage.Sets/src/mage/cards/j/JacobHaukenInspector.java # Mage.Sets/src/mage/cards/u/UginTheIneffable.java # Mage/src/main/java/mage/abilities/keyword/ForetellAbility.java

xenohedron · 2025-11-03T19:41:15Z

@JayDi85 this PR really should not be languishing for so long, it's an important improvement to fix many bugs. If you don't review soon I will.

JayDi85 · 2025-11-03T20:06:16Z

@xenohedron feel free to review any PRs - it will help anyway. Current PR require deep research in gui related changes with card views, hints and images.

Jmlundeen · 2025-11-04T03:53:54Z

It's bee awhile since I've touched this one, I should go through it again

Jmlundeen added 9 commits March 29, 2025 20:02

Fix Yedora and morph cards

bee9982

Remove day/night button after morph card flips Update Yedora to set proper attributes

Refactor BecomesFaceDownCreatureAllEffect

b2b71b3

Uses makeFaceDownObject now

Refactor CardView

c4daef9

reduce cognitive complexity of constructor separating into different functions move some settings into shared function face down cards correctly display information now

Refactor day/night button on card panel

1c2b09a

add day/night button when a card becomes face down properly assign face/back for multi face cards that already have a day/night button and become face down hide the button when a card is no longer transformable

Add foretell image back to CardView

c28f2e1

Track players that can see face-down cards in exile

c5ebcab

gives players the ability to see info on face-down cards for the duration of exile puts game engine more in-line with rule 406.3

Update Gonti, Night Minister

dbc846b

add new exile logic

Update Ixidron

ee91011

filter for creature permanents

Update Bane Alley Broker

1051ea7

give controller ability to look at exiled cards for duration of game

github-actions bot added cards engine client labels Mar 30, 2025

Jmlundeen added 15 commits March 30, 2025 09:57

Copy card visibility when moving between exile zones

c03c6c6

Also remove visibility when removing from exile zone

Update ExileFaceDownYouMayPlayAsLongAsExiledTargetEffect with exile z…

1c5c3a8

…one visibility

Update Arvinox, the Mind Flail

215d8ba

remove unnecessary custom effects with makeCardPlayable and exile zone visibility

Update Colfenor's Plan

9060f8e

add exile zone visibility

Update Ethereal Valkyrie

53c2459

add exile zone visibility

Update Grimoire Thief

a1f3529

add exile zone visibility

Update Gustha's Scepter

3fa3a76

add exile zone visibility remove unnecessary look at effect

Update Headliner Scarlett

44a61ef

update exile effect

Update Hoarding Broodlord

54ef335

update exile effect

Update Hoarding Broodlord

2821a5b

update exile effect

Update Jacob Hauken, Inspector // Hauken's Insight

aa777bb

update exile effect remove unnecessary look effect

Cleanup moveCardsToExileFaceDown Constructors

3e9e379

update related cards that use methods

Update Jester's Scepter

9922720

update exile effect remove unnecessary look at effect

Update Kayla's Music Box

e773be6

update exile effect remove unnecessary look at effect play effect now considers ownership

Create common look at and may play effects

51d4254

created test class for both effects using Kheru Mind-Eater and Colfenor's Plans

github-actions bot added the tests label Mar 31, 2025

Merge branch 'refs/heads/master' into rework-face-down-cards

c622f21

JayDi85 reviewed Apr 1, 2025

View reviewed changes

Mage.Common/src/main/java/mage/view/CardView.java Show resolved Hide resolved

Jmlundeen added 2 commits April 3, 2025 08:53

Update ContinuousEffects

e471e97

After processing copy effects 1a layer, layer effects are refreshed. This allows copied morph cards that were turned face down to have the turn face up ability.

Merge remote-tracking branch 'Xmage/master' into rework-face-down-cards

9de857f

Jmlundeen marked this pull request as ready for review April 5, 2025 14:25

Jmlundeen added 2 commits April 5, 2025 10:40

Remove Look at effect from Foretell

26178e9

Hide face down info from targeting spell on stack

c4c1df1

Jmlundeen added 6 commits April 6, 2025 08:11

CardView missing other end of span

2d4cee0

Revert "Hide face down info from targeting spell on stack"

d60f69d

This reverts commit c4c1df1.

Fix cascade and face down spells

d6ff4da

Cascade now checks the spell instead of the cards mana value

Hide spell target in UI

7c56153

Spell target text, for a spell on the stack, is now hidden if not the controller of target

Create linked object name for face down spell on stack

4341549

face down spells on the stack will log the spell with a linked object and appropriate id

Create linked object name for face down permanents

146df7e

face down permanents create a linked object with id

Merge branch 'refs/heads/master' into rework-face-down-cards

b025f5e

# Conflicts: # Mage.Common/src/main/java/mage/view/CardView.java

JayDi85 self-assigned this May 29, 2025

Jmlundeen added 3 commits September 1, 2025 07:56

remove unused imports

e0de7e4

add Gonti, Night Minister test

34a94d9

PurpleCrowbar mentioned this pull request Feb 13, 2026

Connecting the Dots lets me look at the exiled cards even though it states otherwise #14407

Open

Conversation

Jmlundeen commented Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Jmlundeen commented Apr 3, 2025

Uh oh!

JayDi85 commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JayDi85 commented Apr 5, 2025

Uh oh!

Jmlundeen commented Apr 5, 2025

Uh oh!

Jmlundeen commented Apr 5, 2025

Uh oh!

JayDi85 commented Apr 16, 2025

Uh oh!

Jmlundeen commented Apr 16, 2025

Uh oh!

PurpleCrowbar commented Apr 24, 2025

Uh oh!

JayDi85 commented Apr 24, 2025

Uh oh!

PurpleCrowbar commented Jun 29, 2025

Uh oh!

xenohedron commented Nov 3, 2025

Uh oh!

JayDi85 commented Nov 3, 2025

Uh oh!

Jmlundeen commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jmlundeen commented Mar 30, 2025 •

edited

Loading

JayDi85 commented Apr 5, 2025 •

edited

Loading